Welcome to Geeklog Sunday, November 28 2021 @ 12:32 pm EST

Geeklog Forums

professional_css


Status: offline

ivy

Forum User
Full Member
Registered: 25/11/04
Posts: 314
Location:Tokyo Japan
We Geeklog Japanese group changed theme name 'ProfessionsCSS' to 'professional_css'.

And I added style to admin/config/configuration.thtml, because left side bloack is too narrow.
http://code.google.com/p/geeklog-jp/source/browse/trunk/geeklog-jp/public_html/layout/professional_css/admin/config/configuration.thtml
left: 25% right:75%

and I deleted font-family style on tool tips..
http://code.google.com/p/geeklog-jp/source/browse/trunk/geeklog-jp/public_html/layout/professional_css/jquery_ui/jquery-ui.css

How about this changes.

Thanks.
Geeklog Japan https://www.geeklog.jp
 Quote

Status: offline

Roccivic

Forum User
Moderator
Registered: 19/05/10
Posts: 136
Just pasting this here from our email conversation, as I think that I have a valid point here.

Looks nice, but I'm not sure if it's such a good idea to hardcode widths
into columns. What if there is one really long word in the left column?
It will either get chopped or will overflow into the right frame and
that's not pretty. If you really want to get this change into the theme,
please post about it on the forum or on the devel mailing list, so that
other developers can also have a look and express their opinion.


Rouslan
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1440
Hey Ivy,

and I deleted font-family style on tool tips..
http://code.google.com/p/geeklog-jp/source/browse/trunk/geeklog-jp/public_html/layout/professional_css/jquery_ui/jquery-ui.css


For any jQuery CSS stuff you should probably update the jquery.ui.geeklog.css file. It just makes updating jQuery easier if I do not have to worry about copying over any changes in those files.

And I added style to admin/config/configuration.thtml, because left side bloack is too narrow.
http://code.google.com/p/geeklog-jp/source/browse/trunk/geeklog-jp/public_html/layout/professional_css/admin/config/configuration.thtml
left: 25% right:75%


Your updated column sizes look better. The problem of a really long word that Roccivic mentioned can happen but it could potenially happen anyways even with out the widths specified (ie both columns have a really long word) so for myself I am not to worried about that.

As far as inline styles are concerned I know that they are a no no, but I am guilty of this as well. I think since we have several people working on themes we should develop some sort of html/css standard (at least a basic one) like we do for PHP coding.

For example here are a few questions that I have:

1) Inline styles are usually frowned upon but is it "okay" if it is just one or two items (like setting the text align for a table colum) or should we create a class for that

2) How should are css class definitions look? How about spacing? (ie vertical-align:top; or vertical-align: topWink

3) How should we name classes?

4) etc...

Answering these types of questions will make things a bit easier. As a reference Drupal has started a CSS coding standard http://drupal.org/node/302199

Tom


One of the Geeklog Core Developers.
 Quote

Status: offline

ivy

Forum User
Full Member
Registered: 25/11/04
Posts: 314
Location:Tokyo Japan
Hard coding "left: 25% right:75% " is better, and css style coding is best I think, too.

Geeklog Japan https://www.geeklog.jp
 Quote

Status: offline

Roccivic

Forum User
Moderator
Registered: 19/05/10
Posts: 136
Quote by: Laugh


1) Inline styles are usually frowned upon but is it "okay" if it is just one or two items (like setting the text align for a table colum) or should we create a class for that


Hardcoding text-aligns is especially a bad idea, as I think it will compromise RTL support (we have exactly this problem in the forum plugin ATM). Though I'd have no problems with inline delarations for, say, font-weight.

Quote by: Laugh


Answering these types of questions will make things a bit easier. As a reference Drupal has started a CSS coding standard http://drupal.org/node/302199


It looks good, let's just steal it, like we did with the PEAR standard Big Grin
How is it that we handle RTL anyway? We don't really have conditional CSS file loading mechanism like in Drupal, right?
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 12/01/02
Posts: 13073
Location:Stuttgart, Germany
Quote by: Roccivic

How is it that we handle RTL anyway? We don't really have conditional CSS file loading mechanism like in Drupal, right?


Nope, nothing fancy like this. All you have to go by is the $LANG_DIRECTION variable. I think in some places we set that as a template variable so that you can then use it in CSS class names.

bye, Dirk
 Quote

Status: offline

ivy

Forum User
Full Member
Registered: 25/11/04
Posts: 314
Location:Tokyo Japan
Templates of configuration use table layout.
But I don't like table layout.
Only configuration use table layout in professional_css.


Geeklog Japan https://www.geeklog.jp
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1440
Quote by: ivy

Templates of configuration use table layout.
But I don't like table layout.
Only configuration use table layout in professional_css.



Yeah, that was something I was going to look into at some point but never got around to it. Your more than welcome to submit a patch for it Razz


In regards to the CSS coding standard, I will add it to the wiki using most of what Drupal has and post a link here for others to contribute.
One of the Geeklog Core Developers.
 Quote

All times are EST. The time is now 12:32 pm.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content