Welcome to Geeklog Monday, December 09 2019 @ 06:07 pm EST

Geeklog Forums

Links in stories and comment

Page navigation


Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
Hi,

On Geeklog 1.5.1 a link in a plain text story like http://www.geeklog.net/forum/index.php
is display as www.geeklog.net and point to http://www.geeklog.net/forum/index.php

Is it a new feature?

On Geeklog 1.4.1 link is display as http://www.geeklog.net/forum/index.php

Can we have the same feature on comments?

::Ben
I'm available to customise your themes or plugins for your Geeklog CMS
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 12/01/02
Posts: 13073
Location:Stuttgart, Germany
Yes, COM_makeClickableLinks will now truncate links so that long URLs don't break the layout any more.

That should also work in (text mode) comments.

bye, Dirk
 Quote

Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
That should also work in (text mode) comments.


Seems that do not work...

But without my glasses you know, I can't find the handy checkbox Smile

::Ben
I'm available to customise your themes or plugins for your Geeklog CMS
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 12/01/02
Posts: 13073
Location:Stuttgart, Germany
Works for me. Can you give an example?

bye, Dirk
 Quote

Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
I add http://demo.geeklog.net/comment.php?sid=welcome&pid=0&type=article in a comment on the demo site, I got

demo.geeklog.net&pid=0&type=article

But with http://www.geeklog.net/forum/index.php it's ok. I get a www.geeklog.net. Yesterday was another day Wink

::Ben
I'm available to customise your themes or plugins for your Geeklog CMS
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1384
I'm having similar issues as cordiste.

Is their a way in the config to turn this off (I didn't see it). Dirk do you see any potential problems with other code if I just comment the code out in the COM_makeClickableLinks and COM_undoClickableLinks functions and just return the text


Other Issues:

- Converting text like "geeklog.com" into a url . Even happens on the Admins Only submission page in titles, etc.. (the url are linked incorrectly too)
--- Try putting geeklog.net in the title and/or id of a story to see the problem
- Messes with autotags that contain urls.
--- This in turns screws up the autotag which then screws up other autotags further down in the story.
- At one point (can't reproduce) I also started seeing html in my plain old text post that dealt with the clickable links. Seems like COM_undoClickableLinks wasn't called or something. It had also started to nest links similar to this example:

PHP Formatted Code
<a href="http://www.<a href="http://www.geeklog.net">geeklog.net</a>">geeklog.net</a>





Tom


One of the Geeklog Core Developers.
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
I have a similar problem: just upgraded tot GL1.51, and found out that typing www.domain.com in a plain text story doesn't make a proper link anymore, it doesn't add the http: before the www...

But I'm glad that the links in the excisting 1600 stories are still working fine..
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
I open a bug report. It's number 767.

::Ben
I'm available to customise your themes or plugins for your Geeklog CMS
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
Quote by: cordiste

I add http://demo.geeklog.net/comment.php?sid=welcome&pid=0&type=article in a comment on the demo site, I got

demo.geeklog.net&amp;pid=0&amp;type=article

But with http://www.geeklog.net/forum/index.php it's ok. I get a www.geeklog.net. Yesterday was another day Wink

::Ben



The same problem with static pages: http://www.domain.com/staticpages/index.php/page-id will make http://www.domain.com. The autolink to a static page is also broken/gone.
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
Doesn't anybody else have similar problems? I've dozens of brokens links in my site, and can't repair all of them in html mode since GL still changes some...and the bug is stll not assigned nor solved.

Any chance I can replace the new COM_makeClickableLinks temporarily with an older one?
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1384
I just looked at the old 1.4.1 code and it will work fine in 1.5.1

Remember to replace COM_undoClickableLinks as well.


One of the Geeklog Core Developers.
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
OK, thanks, I will have a look at it tomorrow.
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
Well, replacing it with the GL1.41 functions didn't work out... Still struggling with about a hunderd broken autolinks... :banghead: :helpme:
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1384
Same type of link issue? Give me an example and I'll try to take a look at it tomorrow on one of my sites I've replaced with 1.4.1 code.
One of the Geeklog Core Developers.
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
Over here: http://www.kampeerzaken.nl/article.php/camper-centrum-dronten-rolvink-031008. The 8] used to be {story:camper-centrum-dronten-showroom-270308} (with square brackets of course).
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1384
Quote by: beewee

Over here: http://www.kampeerzaken.nl/article.php/camper-centrum-dronten-rolvink-031008. The 8] used to be {story:camper-centrum-dronten-showroom-270308} (with square brackets of course).



I didn't realize you were talking about a story autotag The story autotag has nothing to do with COM_ClickableLinks and COM_undoClickableLinks. These functions deal with geeklog automatically converting Domain names and URLs text in a story, comment, etc... into a link.

Story autotags get created in lib-plugins in the function PLG_replaceTags.


One of the Geeklog Core Developers.
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
Okay, thanks. I'll leave the replace functions still there, will try to replace the PLG_replaceTags from GL1.41 and report what's happening. When that's solved my problem, I'll file another bugreport.
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
Okay, replaced that complete function, saved the mentioned story again, no improvement at all...Cry

BTW I'm also using the Autotags plugin, could that be part of the problem?
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1384
Quote by: beewee

Okay, replaced that complete function, saved the mentioned story again, no improvement at all...Cry

BTW I'm also using the Autotags plugin, could that be part of the problem?



I checked the page and it seemed to be working now. If you resave the story does the autotag then work?


One of the Geeklog Core Developers.
 Quote

Status: offline

beewee

Forum User
Full Member
Registered: 05/08/03
Posts: 969
Location:The Netherlands, where else?
I'm doing too much projects at the same time, at this moment.. One project is nearly finished, one project has just started and the next project will start in 2 weeks.

So I forgot something Oops! Oops!...
What I did forget to mention is that I just found out that the autotag only works when I use the advanced editor. Normal plain text and html produces the error with the autotag.
Dutch Geeklog sites about camping/hiking: www.kampeerzaken.nl | www.campersite.nl | www.caravans.nl | www.caravans.net
 Quote

Page navigation

All times are EST. The time is now 06:07 pm.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content