Subject: Links in stories and comment

Posted on: 14/10/08 05:07pm
By: ::Ben

Hi,

On Geeklog 1.5.1 a link in a plain text story like http://www.geeklog.net/forum/index.php
is display as www.geeklog.net and point to http://www.geeklog.net/forum/index.php

Is it a new feature?

On Geeklog 1.4.1 link is display as http://www.geeklog.net/forum/index.php

Can we have the same feature on comments?

::Ben

Re: Links in stories and comment

Posted on: 15/10/08 08:28am
By: Dirk

Yes, COM_makeClickableLinks will now truncate links so that long URLs don't break the layout any more.

That should also work in (text mode) comments.

bye, Dirk

Re: Links in stories and comment

Posted on: 15/10/08 01:57pm
By: ::Ben

That should also work in (text mode) comments.


Seems that do not work...

But without my glasses you know, I can't find the handy checkbox Smile

::Ben

Re: Links in stories and comment

Posted on: 15/10/08 01:59pm
By: Dirk

Works for me. Can you give an example?

bye, Dirk

Re: Links in stories and comment

Posted on: 15/10/08 02:06pm
By: ::Ben

I add http://demo.geeklog.net/comment.php?sid=welcome&pid=0&type=article in a comment on the demo site, I got

demo.geeklog.net&pid=0&type=article

But with http://www.geeklog.net/forum/index.php it's ok. I get a www.geeklog.net. Yesterday was another day Wink

::Ben

Re: Links in stories and comment

Posted on: 15/10/08 02:50pm
By: Laugh

I'm having similar issues as cordiste.

Is their a way in the config to turn this off (I didn't see it). Dirk do you see any potential problems with other code if I just comment the code out in the COM_makeClickableLinks and COM_undoClickableLinks functions and just return the text


Other Issues:

- Converting text like "geeklog.com" into a url . Even happens on the Admins Only submission page in titles, etc.. (the url are linked incorrectly too)
--- Try putting geeklog.net in the title and/or id of a story to see the problem
- Messes with autotags that contain urls.
--- This in turns screws up the autotag which then screws up other autotags further down in the story.
- At one point (can't reproduce) I also started seeing html in my plain old text post that dealt with the clickable links. Seems like COM_undoClickableLinks wasn't called or something. It had also started to nest links similar to this example:

PHP Formatted Code
<a href="http://www.<a href="http://www.geeklog.net">geeklog.net</a>">geeklog.net</a>





Tom


Re: Links in stories and comment

Posted on: 27/10/08 03:59am
By: beewee

I have a similar problem: just upgraded tot GL1.51, and found out that typing www.domain.com in a plain text story doesn't make a proper link anymore, it doesn't add the http: before the www...

But I'm glad that the links in the excisting 1600 stories are still working fine..

Re: Links in stories and comment

Posted on: 27/10/08 05:58am
By: ::Ben

I open a bug report. It's number 767.

::Ben

Re: Links in stories and comment

Posted on: 28/10/08 08:56am
By: beewee

Quote by: cordiste

I add http://demo.geeklog.net/comment.php?sid=welcome&pid=0&type=article in a comment on the demo site, I got

demo.geeklog.net&amp;pid=0&amp;type=article

But with http://www.geeklog.net/forum/index.php it's ok. I get a www.geeklog.net. Yesterday was another day Wink

::Ben



The same problem with static pages: http://www.domain.com/staticpages/index.php/page-id will make http://www.domain.com. The autolink to a static page is also broken/gone.

Re: Links in stories and comment

Posted on: 04/11/08 02:49am
By: beewee

Doesn't anybody else have similar problems? I've dozens of brokens links in my site, and can't repair all of them in html mode since GL still changes some...and the bug is stll not assigned nor solved.

Any chance I can replace the new COM_makeClickableLinks temporarily with an older one?

Re: Links in stories and comment

Posted on: 04/11/08 08:28am
By: Laugh

I just looked at the old 1.4.1 code and it will work fine in 1.5.1

Remember to replace COM_undoClickableLinks as well.


Re: Links in stories and comment

Posted on: 04/11/08 09:50am
By: beewee

OK, thanks, I will have a look at it tomorrow.

Re: Links in stories and comment

Posted on: 10/11/08 11:01am
By: beewee

Well, replacing it with the GL1.41 functions didn't work out... Still struggling with about a hunderd broken autolinks... :banghead: :helpme:

Re: Links in stories and comment

Posted on: 10/11/08 12:45pm
By: Laugh

Same type of link issue? Give me an example and I'll try to take a look at it tomorrow on one of my sites I've replaced with 1.4.1 code.

Re: Links in stories and comment

Posted on: 10/11/08 02:23pm
By: beewee

Over here: http://www.kampeerzaken.nl/article.php/camper-centrum-dronten-rolvink-031008. The 8] used to be {story:camper-centrum-dronten-showroom-270308} (with square brackets of course).

Re: Links in stories and comment

Posted on: 11/11/08 12:51pm
By: Laugh

Quote by: beewee

Over here: http://www.kampeerzaken.nl/article.php/camper-centrum-dronten-rolvink-031008. The 8] used to be {story:camper-centrum-dronten-showroom-270308} (with square brackets of course).



I didn't realize you were talking about a story autotag The story autotag has nothing to do with COM_ClickableLinks and COM_undoClickableLinks. These functions deal with geeklog automatically converting Domain names and URLs text in a story, comment, etc... into a link.

Story autotags get created in lib-plugins in the function PLG_replaceTags.


Re: Links in stories and comment

Posted on: 11/11/08 02:14pm
By: beewee

Okay, thanks. I'll leave the replace functions still there, will try to replace the PLG_replaceTags from GL1.41 and report what's happening. When that's solved my problem, I'll file another bugreport.

Re: Links in stories and comment

Posted on: 12/11/08 05:18am
By: beewee

Okay, replaced that complete function, saved the mentioned story again, no improvement at all...Cry

BTW I'm also using the Autotags plugin, could that be part of the problem?

Re: Links in stories and comment

Posted on: 12/11/08 09:27am
By: Laugh

Quote by: beewee

Okay, replaced that complete function, saved the mentioned story again, no improvement at all...Cry

BTW I'm also using the Autotags plugin, could that be part of the problem?



I checked the page and it seemed to be working now. If you resave the story does the autotag then work?


Re: Links in stories and comment

Posted on: 12/11/08 09:36am
By: beewee

I'm doing too much projects at the same time, at this moment.. One project is nearly finished, one project has just started and the next project will start in 2 weeks.

So I forgot something Oops! Oops!...
What I did forget to mention is that I just found out that the autotag only works when I use the advanced editor. Normal plain text and html produces the error with the autotag.

Re: Links in stories and comment

Posted on: 12/11/08 09:52am
By: Laugh

Inregards to the autotags plugin, I doubt it is the cause but you could disable it for a minute to check.

What character set are you using for your site? I had similar problems before with autotags if I had special characters in my story. When I switch to UTF-8 it solved my problems.

Re: Links in stories and comment

Posted on: 12/11/08 10:13am
By: beewee

I'm using iso-8859-1 as character set. It's a bit difficult to switch to UTF-8 because of some external applications. I'll disable the Autotags plugin for a minute.

EDIT: that didn't make any difference..

Re: Links in stories and comment - Event URL not showing in Calender nor Embedded links

Posted on: 14/03/12 04:45pm
By: 1PLM

Hi friends,
I want an event calender I set up to show up for all visitors to the site. I also need the Event URL to show up the correct website when clicked. Everything looks OK but the URL link is not pulling the correct site. What am I missing? Event URL is entered as: http://www.THESITE.com/index.php/news/features/11523-
Thanks.

Partially Solved - Added URLs is Still not showing:

Excuse my haste.
Fist part of issue IS SOLVED. I just had to change the settings under Calender Submissions to 0 (instead of 1), which needs admin approval before a posted event shows).
When set to 1, all posted events needs admin approval before it is seen - but why will an added event by the Super admin not show up immediately until the setting was changed? a security feature I guess.
.

Geeklog - Forum
https://www.geeklog.net/forum/viewtopic.php?showtopic=84889