Welcome to Geeklog Sunday, July 12 2020 @ 03:19 am EDT

Geeklog Forums

Edit icon missing in static pages?


Status: offline

mystral-kk

Site Admin
Admin
Registered: 19/03/06
Posts: 100
Location:Japan

I installed GL-1.5 quite easily (thanks, developers!) and found no edit icon in static pages in the center block (when displaying the home page of my site with the default Professional theme), though I logged in as admin.

After doing a little search through the code, I think this has something to do with geeklog/plugins/staticpages/templates/centerblock.thtml, which doesn't contain {edit_icon} template var. After I added {edit_icon} to the template file, edit icon shows itself as in GL-1.4.1.


-- mystral-kk, "Every cloud has a silver lining."
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 12/01/02
Posts: 13073
Location:Stuttgart, Germany
That was actually a conscious decision:
Static Pages plugin
-------------------
- Moved the print and edit icons to the bottom of a static page in the default
staticpage.thtml template file. Also removed the icons from the default
centerblock.thtml template file and defined the {lastupdate} and {hits}
variables there (bug #0000628 ) [Dirk]

The old template was trying to make it look like a story block, but it didn't quite work out and you don't usually need the printer icon on a centerblock. And then I couldn't find a good spot to put the edit icon, so I took that out as well.

But since it's a template, it's easy to put back in. If you have any suggestion as to where the edit icon should go, let's hear them.

bye, Dirk
 Quote

Status: offline

mystral-kk

Site Admin
Admin
Registered: 19/03/06
Posts: 100
Location:Japan
Thanks for the quick reply, Dirk.

For non-admin users to see the site, I quite agree with you. Date and print icons are of little use. However, for admins to edit static pages, especially when they are designing the static pages, the edit icon which you can click at the home page is quite handy.

So I suggest changing centerblock.thtml like:

{content}
<p class="alignright">{edit_icon}</p>

-- mystral-kk, "Every cloud has a silver lining."
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 12/01/02
Posts: 13073
Location:Stuttgart, Germany
Quote by: mystral_kk

So I suggest changing centerblock.thtml like:

{content}
<p class="alignright">{edit_icon}</p>


That would of course leave an empty paragraph for everyone without edit permissions. Shouldn't hurt, but it's not very elegant.

bye, Dirk
 Quote

Status: offline

jmucchiello

Forum User
Full Member
Registered: 29/08/05
Posts: 985
If you are running CTL you can do this to avoid the extra paragraph for users that can't edit the static page:
{content}
{!if edit_icon}
<p class="alignright">{edit_icon}</p>
{!endif}
 Quote

Status: offline

mystral-kk

Site Admin
Admin
Registered: 19/03/06
Posts: 100
Location:Japan
Quote by: Dirk

Quote by: mystral_kk

So I suggest changing centerblock.thtml like:

{content}
<p class="alignright">{edit_icon}</p>


That would of course leave an empty paragraph for everyone without edit permissions. Shouldn't hurt, but it's not very elegant.


Sure, it's not very elegant, but I would prefer handiness to elegance.

Joe, thanks for your info. I haven't introduced CTL yet, but when I upgrade my site to GL-1.5, I will try CTL.
-- mystral-kk, "Every cloud has a silver lining."
 Quote

Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
+1 for a direct link to edit static pages Smile

::Ben
I'm available to customise your themes or plugins for your Geeklog CMS
 Quote

All times are EDT. The time is now 03:19 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content