Posted on: 06/16/08 09:18am
By: mystral-kk
I installed GL-1.5 quite easily (thanks, developers!) and found no edit icon in static pages in the center block (when displaying the home page of my site with the default Professional theme), though I logged in as admin.
After doing a little search through the code, I think this has something to do with geeklog/plugins/staticpages/templates/centerblock.thtml, which doesn't contain {edit_icon} template var. After I added {edit_icon} to the template file, edit icon shows itself as in GL-1.4.1.
Re: Edit icon missing in static pages?
Posted on: 06/16/08 02:19pm
By: Dirk
That was actually a conscious decision:
Static Pages plugin
-------------------
- Moved the print and edit icons to the bottom of a static page in the default
staticpage.thtml template file. Also removed the icons from the default
centerblock.thtml template file and defined the {lastupdate} and {hits}
variables there (bug #0000628 ) [Dirk]
The old template was trying to make it look like a story block, but it didn't quite work out and you don't usually need the printer icon on a centerblock. And then I couldn't find a good spot to put the edit icon, so I took that out as well.
But since it's a template, it's easy to put back in. If you have any suggestion as to where the edit icon should go, let's hear them.
bye, Dirk
Re: Edit icon missing in static pages?
Posted on: 06/17/08 08:56am
By: mystral-kk
Thanks for the quick reply, Dirk.
For non-admin users to see the site, I quite agree with you. Date and print icons are of little use. However, for admins to edit static pages, especially when they are designing the static pages, the edit icon which you can click at the home page is quite handy.
So I suggest changing centerblock.thtml like:
{content}
<p class="alignright">{edit_icon}</p>
Re: Edit icon missing in static pages?
Posted on: 06/17/08 12:41pm
By: Dirk
Quote by: mystral_kkSo I suggest changing centerblock.thtml like:
{content}
<p class="alignright">{edit_icon}</p>
That would of course leave an empty paragraph for everyone without edit permissions. Shouldn't hurt, but it's not very elegant.
bye, Dirk
Re: Edit icon missing in static pages?
Posted on: 06/17/08 02:09pm
By: jmucchiello
If you are running CTL you can do this to avoid the extra paragraph for users that can't edit the static page:
{content}
{!if edit_icon}
<p class="alignright">{edit_icon}</p>
{!endif}
Re: Edit icon missing in static pages?
Posted on: 06/18/08 10:35am
By: mystral-kk
Quote by: DirkQuote by: mystral_kkSo I suggest changing centerblock.thtml like:
{content}
<p class="alignright">{edit_icon}</p>
That would of course leave an empty paragraph for everyone without edit permissions. Shouldn't hurt, but it's not very elegant.
Sure, it's not very elegant, but I would prefer handiness to elegance.
Joe, thanks for your info. I haven't introduced CTL yet, but when I upgrade my site to GL-1.5, I will try CTL.
Re: Edit icon missing in static pages?
Posted on: 06/18/08 10:57am
By: ::Ben
+1 for a direct link to edit static pages
::Ben