Welcome to Geeklog, Anonymous Sunday, November 10 2024 @ 07:01 pm EST
Geeklog Forums
lib-syndication.php for same date
OMAL
Anonymous
On my site, there are articles with same date in same topic.
This caused an issue.
ref.
https://github.com/Geeklog-Core/geeklog/blob/master/public_html/lib-common.php
https://github.com/Geeklog-Core/geeklog/blob/master/system/lib-syndication.php
SYND_feedUpdateCheck() is called in line 2258, and SYND_updateFeed() is called in line2268.
SYND_feedUpdateCheck() calls SYND_feedUpdateCheckTopic() in which sql is sorted by date in line 149. In the same way, SYND_updateFeed() calls SYND_getFeedContentPerTopic() in which sql is sorted by date in 254.
For the Sid with exactly same date, those two returns different order.
So this should be ordered by date AND SID like the following, to fix this issue.
If Geeklog doesn't allow post articles with same date for same topic, it doesn't occur. My site is customized a lot, and there are articles with same date, so it happens.
This caused an issue.
ref.
https://github.com/Geeklog-Core/geeklog/blob/master/public_html/lib-common.php
https://github.com/Geeklog-Core/geeklog/blob/master/system/lib-syndication.php
SYND_feedUpdateCheck() is called in line 2258, and SYND_updateFeed() is called in line2268.
SYND_feedUpdateCheck() calls SYND_feedUpdateCheckTopic() in which sql is sorted by date in line 149. In the same way, SYND_updateFeed() calls SYND_getFeedContentPerTopic() in which sql is sorted by date in 254.
For the Sid with exactly same date, those two returns different order.
So this should be ordered by date AND SID like the following, to fix this issue.
Text Formatted Code
ORDER BY date DESC, sidIf Geeklog doesn't allow post articles with same date for same topic, it doesn't occur. My site is customized a lot, and there are articles with same date, so it happens.
28
18
Quote
Status: offline
Laugh
Site Admin
Admin
Registered: 09/27/05
Posts: 1470
Location:Canada
Thanks for the report.
Add it to github:
https://github.com/Geeklog-Core/geeklog/issues/1091
By the way you are more than welcome to add the issues as well to github.
Thanks
One of the Geeklog Core Developers.
Add it to github:
https://github.com/Geeklog-Core/geeklog/issues/1091
By the way you are more than welcome to add the issues as well to github.
Thanks
One of the Geeklog Core Developers.
18
27
Quote
All times are EST. The time is now 07:01 pm.
- Normal Topic
- Sticky Topic
- Locked Topic
- New Post
- Sticky Topic W/ New Post
- Locked Topic W/ New Post
- View Anonymous Posts
- Able to post
- Filtered HTML Allowed
- Censored Content