Welcome to Geeklog, Anonymous Monday, April 22 2024 @ 02:57 am EDT

Geeklog Forums

Some typo. of Block's name in Polls plugin.


Status: offline

Phize

Forum User
Newbie
Registered: 08/06/07
Posts: 2
Dear all:

Hello, this's my first time to post a message here.
I'm Phize which is a member of Geeklog Japanese.

Now, I found some problems in Polls plugin, and I think those due to typo. of Block's name.

At first, 'polls_block' is set for Polls plugin's 'name' filed of 'gl_blocks' table in DB.
But, in /plubins/polls/functions.inc, 'poll_block' is set for creating HTML by template classes.

This typo. causes some problems.
For example, poll plugin's HTML in left/right block is created by using center block's templates(blockheader.thtml, blockfooter.thtml).
So I modifed them as the followings.

/plugins/polls/functions.inc
---
616: $title = DB_getItem( $_TABLES['blocks'], 'title', "name='polls_block'" );
630: $retval .= COM_startBlock( $title, '', COM_getBlockTemplate( 'polls_block', 'header' ));
651: $retval .= COM_endBlock( COM_getBlockTemplate( 'polls_block', 'footer' ));
---

I hope these problems are corrected in official package.

Finally,
thank you for every great work, I respect you in Geeklog.net.

Best Regards.

---------------
Phize
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 01/12/02
Posts: 13073
Location:Stuttgart, Germany
Thanks for spotting this. The situation is actually somewhat more confusing, though.

On a fresh install of Geeklog 1.4.0 or 1.4.1, the block will be named 'polls_block'. However, when you upgrade from an older version, the block will keep its old name, which was 'poll_block' - without the 's' Confused

We'll have to stick with one name (most likely "polls_block", since it's the Polls plugin after all) and clean up the upgrade process (and adopt your suggested fix).

bye, Dirk
 Quote

Status: offline

Phize

Forum User
Newbie
Registered: 08/06/07
Posts: 2
Hello, Dirk.
Thanks for your quick response, and new information for us.

We knew those problems come from the process of upgrading.
Then we'll fix them and release our next package in the near future.

Thanks again.


-----------------------------------------
Geeklog Japanse and Phize
 Quote

All times are EDT. The time is now 02:57 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content