Welcome to Geeklog, Anonymous Friday, May 03 2024 @ 03:29 am EDT

Geeklog Forums

Overriding/Inheriting COM_*** function

Post New Reply

Author:

Mood:

Code

Font Color Font Size Close Tags

Forum BBCode Help

BBCode	Effect
[b]bolded text[/b]	bolded text
[i]italicized text[/i]	italicized text
[u]underlined text[/u]	underlined text
[s]strikethrough text[/s]	strikethrough text
[img]http://www.site.com/forum/images/forum.png[/img] OR [img h=65 w=50]http://www.site.com/forum/images/forum.png[/img]
[url=https://www.geeklog.net]Geeklog[/url]	Geeklog
[quote]quoted text[/quote]	To quote: quoted text
[size=15]Your Text[/size] "12" is usually standard on message boards. Usually measured in pixels (px).	Your Text
[color=red]Red Text[/color] OR [color=#FF0000]Red Text[/color] Can use many different color names or hex codes.	Red Text
[list] []List item 1 []List item 2 [/list] OR [list=1] []List item 1 []List item 2 [/list]	List item 1 List item 2 List item 1 List item 2
[code]monospaced text[/code]	monospaced text
[code=XYX]formatted code[/code] Where XYZ can be any of the following: c css html4strict java javascript jquery perl php plain python SQL and many more...	formatted code
To enter a backslash (\) in your post, use \\\\	\

Subject

[QUOTE][u]Quote by: jmucchiello[/u][p]Isn't the array that COM_getBlockTemplate uses to find the template files is already in the theme's functions.php file? The example from kino could just be outside a function in the functions.php file. There's no reason to update the BLOCK_TEMPLATE structure every time there a call to COM_getBlockTemplate. In fact doing so slows your system down since the SQL will return the same data. On my test system I added:

echo "Call to COM_getBlockTemplate(blockname=$blockname, which=$which)<br>";

to COM_getBlockTemplate and it seems it was called 12 times. That's twelve times you would be hitting the blocks table per website hit and of course that's silly since the details in the blocks table will not change during a single website hit.

If you really need this kind of functionality, you ask them to do the function correctly.
[code]function COM_getBlockTemplate( $blockname, $which )
{
    global $_BLOCK_TEMPLATE, $_COM_VERBOSE;

if ($_COM_VERBOSE) {
        COM_errorLog( "_BLOCK_TEMPLATE[$blockname] = " . $_BLOCK_TEMPLATE[$blockname], 1 );
    }

$function = $_CONF['theme'] . '_getBlockTemplate';
    if (function_exists($function)) {
        $template = $function($blockname, $which);
        if (!empty($template)) {
             return $template;
        }
    }
// rest of code[/code]The kino's example should be:
[code]
$_BLOCK_TEMPLATE = Array();

function Theme_getBlockTemplate( $blockname, $which ){
    global $_TABLES,$_BLOCK_TEMPLATE;

if (empty($_BLOCK_TEMPLATE)) {
        $result = DB_query ("SELECT onleft,name FROM {$_TABLES['blocks']} WHERE is_enabled = 1 " . COM_getPermSQL('AND'));
        $nrows = DB_numRows ($result);
        for ($i = 0; $i < $nrows; $i++) {
            $A = DB_fetchArray ($result);
            if ($A['onleft'] == 1) {
                $_BLOCK_TEMPLATE[$A['name']] = 'blockheader-left.thtml,blockfooter-left.thtml';
            } else {
                $_BLOCK_TEMPLATE[$A['name']] = 'blockheader-right.thtml,blockfooter-right.thtml';
            }
        }
    }
    return ''; // empty return falls through for normal processing
}[/code]
And of course, as I said, this could also be:
[code]//inside functions.php of the theme:

$_BLOCK_TEMPLATE = Array();
$result = DB_query ("SELECT onleft,name FROM {$_TABLES['blocks']} WHERE is_enabled = 1 " . COM_getPermSQL('AND'));
$nrows = DB_numRows ($result);
for ($i = 0; $i < $nrows; $i++) {
    $A = DB_fetchArray ($result);
    if ($A['onleft'] == 1) {
        $_BLOCK_TEMPLATE[$A['name']] = 'blockheader-left.thtml,blockfooter-left.thtml';
    } else {
        $_BLOCK_TEMPLATE[$A['name']] = 'blockheader-right.thtml,blockfooter-right.thtml';
    }
}[/code]
But I digress. Using debug tracing to allow functions to call out to other functions and back is much more safely done using controlled return codes. An empty return from THEME_getBlockTemplate is also much easier to understand for new readers of the code.[/p][/QUOTE]

Options:

HTML Mode

Geeklog Forums

Search

Resources

About

Getting started

Support

Development

Topics

User Functions

What's New

Articles last 4 weeks

Comments last 4 weeks

Pages last 4 weeks

Links last 4 weeks

Downloads last 4 weeks