Welcome to Geeklog Monday, June 25 2018 @ 04:03 am EDT

Geeklog Forums

Facebook Comments


Status: offline

gtgillis

Forum User
Full Member
Registered: 05/11/03
Posts: 121
Location:Spring, TX
cheerful
I am currently testing the addition of Facebook comments to the SocialShare plugin for Geeklog. I still have some work to do cleaning it up before I release it but I wanted to try and get people to take a look and leave comments on my test site to make sure I haven't missed something.

See www.rudebastard.com

Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
Nice job Greg.

Could it be a config setting :
1. not use facebook comment with SocialShare plugin
2. only display facebook comment form on article.php page

Also, I noticed the Share links don't work on your site.

Thanks,

Ben
I'm available to customise your themes or plugins for your Geeklog CMS

Status: offline

gtgillis

Forum User
Full Member
Registered: 05/11/03
Posts: 121
Location:Spring, TX
The share links are fixed.

I plan on having a config setting to enable or disable the comments and share links.

I'll also add a setting to only show the comments on the individual article pages.

Regards,

Greg

Quote by: ::Ben

Nice job Greg.

Could it be a config setting :
1. not use facebook comment with SocialShare plugin
2. only display facebook comment form on article.php page

Also, I noticed the Share links don't work on your site.

Thanks,

Ben


Status: offline

::Ben

Forum User
Full Member
Registered: 14/01/05
Posts: 1569
Location:la rochelle, France
I plan on having a config setting to enable or disable the comments and share links.

I'll also add a setting to only show the comments on the individual article pages.


Very good news.

Thanks,

Ben
I'm available to customise your themes or plugins for your Geeklog CMS

Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1281
Was the new Social Share plugin ever released?
One of the Geeklog Core Developers.

Status: offline

gtgillis

Forum User
Full Member
Registered: 05/11/03
Posts: 121
Location:Spring, TX
Quote by: Laugh

Was the new Social Share plugin ever released?



I am waiting until GL 2.0 comes out since it may break the current plugin code.

Status: offline

samstone

Forum User
Full Member
Registered: 29/09/02
Posts: 820
Since Geeklog 2.0 Beta is out, are you ready to release a beta version for us to test it out?

Thanks!

Sam

Status: offline

gtgillis

Forum User
Full Member
Registered: 05/11/03
Posts: 121
Location:Spring, TX
I just installed the beta today so I can start porting the plugin.

Quote by: samstone

Since Geeklog 2.0 Beta is out, are you ready to release a beta version for us to test it out?

Thanks!

Sam


Status: offline

Laugh

Site Admin
Admin
Registered: 27/09/05
Posts: 1281
Hey Sam,

I found a few things for you to update when you release the socialshare plugin. I was doing some markup evaluations and found a few errors.

First the links you store in the db for the social networks. You should be using the html entity fo & in your urls like so:

PHP Formatted Code
http://www.google.com/bookmarks/mark?op=edit&amp;bkmk=<SHAREURL>&amp;title=<SHARETITLE>&amp;annotation=<SHARETEXT>


instead of

PHP Formatted Code
http://www.google.com/bookmarks/mark?op=edit&bkmk=<SHAREURL>&title=<SHARETITLE>&annotation=<SHARETEXT>



The second item deals with when you add the html for the socialshare. instead of having:

PHP Formatted Code
$html = '<link rel="stylesheet" href="'.$_CONF['site_url'].'/socialshare/sociable.css" type="text/css" media="screen" charset="utf-8">';


you should use Geeklogs API and create the function plugin_getheadercode_socialshare so that the link automatically gets added to the pages header like so:


PHP Formatted Code

function plugin_getheadercode_socialshare()
{
    global $_CONF;
   
    $html = '<link rel="stylesheet" href="'.$_CONF['site_url'].'/socialshare/sociable.css" type="text/css" media="screen" charset="utf-8">';
    return $html;
}
 


That's it :-)

Thanks

Tom
One of the Geeklog Core Developers.

All times are EDT. The time is now 04:03 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content