Welcome to Geeklog, Anonymous Wednesday, December 07 2022 @ 10:05 pm EST

Geeklog Forums

Future of the Forum plugin

Page navigation


Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
First of all let me say I know very little about the different version control systems :wink:

I was thinking either Mercurial or Google Code since that is what the 2 communities use. IMO I wouldn't really want to add a third option.

I did do a bit of research and it looks like Google did choose to go ahead and add Mercurial to Google Code

http://arstechnica.com/open-source/news/2009/04/google-code-adds-mercurial-version-control-system.ars

http://code.google.com/p/support/wiki/MercurialFAQ

Dengen
I have downloaded it and will be trying it out.

Would you be willing to move your updated forum to our repository and use our repository instead of our own when adding features/fixes or whould you rather us use your repository?

Tom
One of the Geeklog Core Developers.
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 01/12/02
Posts: 13073
Location:Stuttgart, Germany
Quote by: Laugh

Would you be willing to move your updated forum to our repository and use our repository instead of our own when adding features/fixes or whould you rather us use your repository?


For this to be a community effort, it should be hosted somewhere else really. We don't have the infrastructure to give people access to the repositories on our server that would be required for such an effort.

I only mentioned bitbucket above in response to the suggestion to move to github. It's for the maintainers of the plugin to decide where and how they want to host it.

bye, Dirk
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Quote by: Dirk

For this to be a community effort, it should be hosted somewhere else really. We don't have the infrastructure to give people access to the repositories on our server that would be required for such an effort.


Exactly. We are therefore in need of.
But the problem is not that there is no repository. The problem is that the absence of the main maintainer.
We are willing to commit immediately to the main maintainer.

dengen
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
I tried to install Forum plugin Ver2.7.4.JPr1 to Geeklog 1.8.0hg (changeset 8195).
Seemed to work fine. Big Grin
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
>>For this to be a community effort, it should be hosted somewhere else really. We don't have the infrastructure to give people access to the repositories on our server that would be required for such an effort.

Okay then, so the question becomes what VCS and where do we want to host? I still vote for Mercurial as it is the one used by Geeklog (and easier for me :winkSmile and we could host either on bitbucket or Google Code. We would be using this for the forum currently but I do see it expanding to other plugins that have lost their maintainers. I know Git has been mentioned, I have never used it but am open to try it if enough people feel we should use it.

It looks like as of yet that we do not have a "main maintainer" but have a few people willing to work on it. Let's move forward and see how it works out and if/when someone wants to become the main maintainer we can give them control.

Tom
One of the Geeklog Core Developers.
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 01/12/02
Posts: 13073
Location:Stuttgart, Germany
Quote by: Laugh

It looks like as of yet that we do not have a "main maintainer" but have a few people willing to work on it.


Which makes it even more important to have this in a public place where it's easy to add new contributors.

Quote by: Laugh

Let's move forward and see how it works out and if/when someone wants to become the main maintainer we can give them control.


Exactly. Go, go, go :shakehands:

bye, Dirk
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Quote by: Laugh

It looks like as of yet that we do not have a "main maintainer" but have a few people willing to work on it. Let's move forward and see how it works out and if/when someone wants to become the main maintainer we can give them control.


Thanks. We are willing to cooperate.

Quote by: Laugh

We would be using this for the forum currently but I do see it expanding to other plugins that have lost their maintainers.


Agree. In addition to Forum plugin, Geeklog Japanese team is maintaining Filemgmt plugin.
 Quote

Status: offline

Roccivic

Forum User
Moderator
Registered: 05/19/10
Posts: 136
I had a quick go at installing geeklog.jp's forum and it seems to be infested with E_ALL errors.

For example, in functions.inc:
Text Formatted Code
if (!defined(CSRF_TOKEN)) {
should be:
Text Formatted Code
if (!defined('CSRF_TOKEN')) {


and, even better, all those defines with if statements could just be trimmed down to:
Text Formatted Code
defined('XHTML') or define('XHTML', '');
defined('GL_VERSION_15') or define('GL_VERSION_15', (version_compare(VERSION, '1.5') >= 0));
defined('CSRF_TOKEN') or define('CSRF_TOKEN', 'token');


and in config.php:
Text Formatted Code
if (function_exists(CUSTOM_MOBILE_is_cellular) && CUSTOM_MOBILE_is_cellular()) {
should be:
Text Formatted Code
if (function_exists('CUSTOM_MOBILE_is_cellular') && CUSTOM_MOBILE_is_cellular()) {

:twocents:

Rouslan
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Quote by: Roccivic

I had a quick go at installing geeklog.jp's forum and it seems to be infested with E_ALL errors.


Thank you for suggestions. Big Grin

dengen
 Quote

Status: offline

Roccivic

Forum User
Moderator
Registered: 05/19/10
Posts: 136
Quote by: jmucchiello

I'd rather see the smileys and file upload support moved to the core comment system and then create a forum engine based on that.



How about getting the filemgmt plugin to provide it's file upload functionality to the forum and comments, etc?

Rouslan
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
I had a quick go at installing geeklog.jp's forum and it seems to be infested with E_ALL errors.


So is the orginal forum. Big Grin

We should add this to the forum bugtracker.


Okay, unless anyone else has suggestions I plan to set up a Mercurial repository in Google Code for the forum plugin. I will use the latest version form Geeklog JP and add in the few tooltip items I need too and increase the version number to 2.7.5 that still supports Geeklog 1.6.0

Does this sound good Cordiste? (you did express an interest in helping code a few new features for the forum)

Anyone from the Geeklog Commuity with some development experience who wants commit access to the new repository (like our friends from Geeklog JP) would just have to ask. For people who want to code new features in the forum plugin all I would suggest is that we discuss it in this forum topic first before starting work.

The idea would be also to include other plugins people would like to work on who have lost their maintainer.
One of the Geeklog Core Developers.
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Just now, I committed version 2.7.5.JPr1 to our Google Code repository.
This version is merged original version 2.7.5.
Therefore, supports tooltip, and still supports Geeklog 1.6.0.

http://code.google.com/p/geeklog-jp/source/detail?r=2922

dengen
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
I was just about to start working on making the tooltip stuff backwards compatible, thanks.

In your upgrade procedure you probably should add the regular forum versions to the case statement as well (2.7.3 and 2.7.4)
i.e.

Text Formatted Code

            case "2.7.2.JPr5" :
            case "2.7.2.JPr6" :
            case "2.7.3" :
            case "2.7.3.JPr1" :
            case "2.7.4" :


I also notice in some of the diffs that code like


Text Formatted Code
if (!defined('XHTML')) {               
    define('XHTML', '');               
}


has been deleted (see /trunk/geeklog-jp/plugins-jp/forum/include/gf_format.php for example). I am not sure if that was your intention...


Also do you want us to create a new repository or should we just work from yours?


One of the Geeklog Core Developers.
 Quote

Status: offline

::Ben

Forum User
Full Member
Registered: 01/14/05
Posts: 1569
Location:la rochelle, France
Does this sound good Cordiste?


Yes tell me what I need to do to have commit access to the new repository.

I would like to work on:
Attachments - Allow users to upload files (texts, images)
Improve BBCode

Ben
I'm available to customise your themes or plugins for your Geeklog CMS
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Quote by: Laugh

In your upgrade procedure you probably should add the regular forum versions to the case statement as well (2.7.3 and 2.7.4)
i.e.

Text Formatted Code

            case "2.7.2.JPr5" :
            case "2.7.2.JPr6" :
            case "2.7.3" :
            case "2.7.3.JPr1" :
            case "2.7.4" :


Yes. And, JPr version may be deleted.

Quote by: Laugh

I also notice in some of the diffs that code like

Text Formatted Code
if (!defined('XHTML')) {               
    define('XHTML', '');               
}

has been deleted (see /trunk/geeklog-jp/plugins-jp/forum/include/gf_format.php for example). I am not sure if that was your intention...


This code was unnecessary on Geeklog version 1.6.0 or later.

Quote by: Laugh

Also do you want us to create a new repository or should we just work from yours?


I think we should create a new repository sensible.
We will need to fix on the new repository.
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
Okay I will set one up today then and let you guys know the details.
One of the Geeklog Core Developers.
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
Okay,

I wasn’t sure of the best way to approach this.

We can either create one project and have many repositories under it or create a project for each plugin as needed.

I decided to go with one project with multiple repositories. I figured it would be easy to maintain this way but I do not think we can specify committers based on just the repository. It is project specific so this means committers has access to all repositories in the project.


I have created a Geeklog Code project here:

http://code.google.com/p/geeklog/

I haven't used Google Code before so I hope I have done the initial setup correctly. Dengen if there is a better way let me know or you can do the changes yourself (I have given you Admin privileges). I have created a new repository under this project for the forum here:

https://forum.geeklog.googlecode.com/hg/

Dengen do you want to upload the initial files for the forum?

Cordiste I have given you Admin privileges as well (let me know if I used the right email account for you or if I need to change it).

I figure the 3 of us is enough Admins for now. Anyone else who wants to contribute can be added in as Project committers.

Sound good?

Tom

One of the Geeklog Core Developers.
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Quote by: Laugh

Sound good?


Thank you for your hard work and perseverance.

Quote by: Laugh

Dengen if there is a better way let me know or you can do the changes yourself.


I'm not have much experience about project management. Let's go forward step by step.

Quote by: Laugh

Dengen do you want to upload the initial files for the forum?


I'll try. Big Grin
 Quote

Status: offline

dengen

Site Admin
Admin
Registered: 05/03/07
Posts: 37
Location:Japan
Upload finished. I wondered whether the original version or the Japanese version. After all, based on the Japanese version.
 Quote

Status: offline

Laugh

Site Admin
Admin
Registered: 09/27/05
Posts: 1447
Thanks.

I wondered whether the original version or the Japanese version.


Not sure what you mean here... If you are asking what we should use for the version number 2.7.5.JPr1 or 2.7.5

I would say 2.7.5 since this version is for everybody.

I will do some testing and update some of the readme files to include the latest list of changes. Better yet I will just combine all the files as one and list it similar to the Geeklog history file.
One of the Geeklog Core Developers.
 Quote

Page navigation

All times are EST. The time is now 10:05 pm.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content