Welcome to Geeklog, Anonymous Thursday, March 28 2024 @ 05:01 am EDT

Geeklog Forums

Commenting in right to left sites


Status: offline

LWC

Forum User
Full Member
Registered: 02/19/04
Posts: 818
Both public_html/layout/professional/comment/comment.thtml and thread.thtml contain the line div...style="padding-left:...

Which means there's not even the slightest space when the site is viewed in RTL mode.
Having no spaces is especially bad in "nested" mode because it basically just turns into a "flat" mode!

Now, instead of finding a way to detect if the site is in RTL mode not, what's wrong with just div...style="padding:... (i.e. not declaring "padding-left")?

The lack of "padding-left" doesn't seem to affect either LTR or RTL mode.
Now both automatically have spaces in the right (pardon the pun) direction.

So who needs the "padding-left" anyway? I propose to remove it!

In other words, in Geeklog v1.4 (I'm not predicting the future, just updating this post...):

public_html/layout/professional/comment/comment.thtml :
Text Formatted Code
<!-- custom code - start -->
<p>
<div class="comment" style="padding: {indent}px">
<!-- custom code - end -->
  <div class="commenttitle">{title}</div>
  <div>{lang_authoredby} {start_author_anchortag}{author}{end_author_anchortag} {lang_on}
{date}</div>
<!-- custom code - start -->
    <div style="verticle-align: top"><p>{comments}</div>
<!-- custom code - end -->
  <div>

 

All I've done was replacing "padding-left" with just "padding".
Then I've also taken the liberty to add line breaks to make the comments a lot more comfortable to read.

public_html/layout/professional/comment/thread.thtml :
Text Formatted Code
<!-- custom code - start -->
<div style="padding: {indent}px">
<!-- custom code - end -->
  <ul style="margin: 0; padding: 0"><li>

 

Again, all I've done was replacing "padding-left" with just "padding".

I hope to see this applied officially!
 Quote

Status: offline

drshakagee

Forum User
Full Member
Registered: 10/01/03
Posts: 231
Not sure but are you talking about the Professional theme?
Yes I am mental.
 Quote

Status: offline

LWC

Forum User
Full Member
Registered: 02/19/04
Posts: 818
Yes, it's not developed anymore in its developer's site, but it is Geeklog's official theme after all, so I figured I should address it as an integrarl part of Geeklog.
 Quote

All times are EDT. The time is now 05:01 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content