Welcome to Geeklog, Anonymous Saturday, July 13 2024 @ 11:49 am EDT

Geeklog Forums

gl comment engine


Status: Banned

machinari

Forum User
Full Member
Registered: 03/22/04
Posts: 1512
problem: comment engine returning comments from one plugin to another.

detail: for example, if i set a poll id to something that happens to match a filemgmt file id, and comments exist for either plugin's entry by that id, then those comments will be displayed for both the file and the poll.

to fix this, just ensure that the query for comments includes a "where type={plugin}" or something like that.

The other option would be to ensure that ALL plugins use com_makesid for their entry id's--this is unlikely.

I submitted a bug report, but thought I'd make that known here as well. This isn't really a problem with the comment engine (beyond it's lack of checking this); rather it is a problem with those plugins that employ the engine, like the filemgmt plugin to name but one. To be fair though, it may be one of those half full/half empty issues.

all that just to say that I am currently debugging the new photo gallery's implementation of gl's comment engine.
 Quote

Status: Banned

machinari

Forum User
Full Member
Registered: 03/22/04
Posts: 1512
While I'm at it, let me add:

deleting a comment is left up to the plugin. this is good.
...but saving the comment is not left up to the plugin. there is a presave call and a post save call (plghandlecomment) to the plugin's code.

if saving a comment were also left up to the plugin, the plugin could have it's own comments table, which would at the very least fix the comment id (sid) issue i mention in my previous post.

also, when hitting the reply button the comment bar's form action is set to article.php which then simply redirects to comment.php--this seems to be a quick fix left over.

and other things that are making my life difficult atm Neutral
 Quote

Status: offline

Blaine

Forum User
Moderator
Registered: 07/16/02
Posts: 1232
Location:Canada
You might want to look at the comment API changes in CVS that will be GL 1.3.12 as Vince has addressed several issues. I've also re-written the comment functions in the filemgmt plugin to use the CVS version of the API's and can send you over a copy of the plugin if you want.

Send me a PM with your email address if you want a copy to test with the CVS code.
Geeklog components by PortalParts -- www.portalparts.com
 Quote

All times are EDT. The time is now 11:49 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content