Welcome to Geeklog Thursday, December 14 2017 @ 01:06 am EST


Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
I had to enter it manually--googlebot is killing me.

anyways, added category management page, a few tweeks here and there, some suggestions applied, some bugs fixed. Didn't get to deal with the ton of buttons on the catman page, but for now it'll do. haven't had time to figure out the forms just yet. it's all fully functional though, as far as i can tell.
An upgrade script is available.

I'm calling it rc1 due to the addition of the cat man page. I'm sure I haven't caught everything yet. find it here.

I cleaned up the cat listing on the add and manage forms for you jhackwith.

and shetzel, it isn't the search page that is redundant, but the search form on the manage page--now that all regular listing quotes and search results have an edit link that shoots the quote to the manage page. So once on the manage page with the "clicked on edit" quote there ready for editing, you don't need to use the form on that page.

And i left the google links for now as simply on/off--didn't see jason's suggestion in time. perhaps next week.

Enjoy!

Jill

Anonymous
We have upgraded successfully to 1.0.4 without any problem...

LOVE the new edit link. Life is so much easier! Very cool indeed...thankyou thankyou thankyou

One very very tiny issue: on the add page there is no label for the category field? (if you're adding a new category that is...)

Jill

Jill

Anonymous
Ah ok that was our problem. We tried re-copying the language file to the server and everything is now behaving the way it should....

Very cool...
Jill

Status: offline

MrHyde

Forum User
Junior
Registered: 09/11/2003
Posts: 15
Quote by machinari:
just a thought... the source field would then be your title and appear above your quote.

but if you are intent on hitting the code, keep in mind that the quotes are selected in a number of places: functions.inc; index.php; search.php; manage.php; moderate.php. In all those places, the select statements are similar but not exact--your field will have to be represented in all those places. then the display involves setting the variables in the proper functions,, editing the template to reflect those variables... and so on. don't forget about the input--check it for nasty bits. etc.


I'll stick to your method for now. I did the other way and got it working, but it is too much of a pain having to redo all the code changes whenever a new version comes out.

Thanks once again.

Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
OK, I may have a problem with 1.0.4rc1 and the category management....

I did something extreme (which usually finds bugs) and disabled all the categories. I keep getting this one quote (from the "Miscellany" category) that comes up every time. Since I disabled "Miscellany", I would have expected nothingness. When I enabled another small category (2 entries), the random quote generated was one of those three (2 from "Books", or the same one from "Miscellany").

There could be a bug with my quote importation script, but my data looks good. Could someone else try this as described and see what happens?

Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
Second question: Where are the category enable/disable fields kept? I kinda thought it might be in 'gl_dailyquote_category', but I am apparently mistaken. It might help me figure out my next problem.

After I disabled all the categories, I tried to re-enable all of them. For some reason, I can't re-enable the "Miscellany" category. It might be doing it. It gives me a success message. But the catman page redisplays with a button set in the "disable". Weird.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by shetzel:Could someone else try this as described and see what happens?
well, I tried it. I wasn't able to reproduce that oddity. It worked properly for me and after all cats were disabled, there "was nothingness."

Only thing I can think of without actually being able to reproduce the problem, is that the value didn't get set on that category in the table. but that should never happen.

a quick way to see which cats are actually enabled without going into the db is to go to the add quote page. the categories are displayed there with disabled ones greyed over and all others are still bold black. you can check up on the miscellany cat there.

the "Status" field in the quotes table as well as the categories table are for moderation, while it is the "Status" field in the lookup table that is responsible for enabling/disabling categories. that means that a category will only be enabled or disabled if there is a quote belonging to that category (just an aside).

maybe if you can tell me how the miscellany category was created at first??? It isn't created by default, but once it is created (either by you or by the script under certain circumstances), then it functions ever so slightly different then all other categories. eg, not being able to be deleted.

hope some of that helps.. Let me know, K?

on the good side, disabling all cats did show me a problem with the cached quote function. an oversight that continues to show the cached quote though all categories it may belong to are disabled.

Status: offline

jhackwith

Forum User
Chatty
Registered: 24/07/2004
Posts: 63
Location:Lewiston, Idaho
full
Upgraded to 1.0.4, everything is working except for one minor problem:

I'm getting doubled quotes on the main listings page. See http://www.intotheflame.com/dailyquote/index.php for an example... I get two of each quote listed.

Thanks again for all your hard work!
"Beauty... is the shadow of God on the universe." ~ Gabriela Mistral -- Desolacíon

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by jhackwith:
I'm getting doubled quotes on the main listings page.

change line 100 in index.php from this:
PHP Formatted Code
    $sql = "SELECT q.ID, Quotes, Quoted, Source, Sourcedate, Date, q.UID";



 
to this:
PHP Formatted Code
    $sql = "SELECT DISTINCT q.ID, Quotes, Quoted, Source, Sourcedate, Date, q.UID";



 

that should do it.. though it shouldn't be happening on that page. that is to say that it isn't happening for me sorry about that oversight. let me know if it doesn't do the trick.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by jhackwith:I'm getting doubled quotes on the main listings page.
also, did you successfully replace the index.php page with the 1.0.4 version? there were a few minor changes necessary to accomodate the cat man page.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
features that will make it into the 1.0.4 final include:
* enable/disable ALL button on the category management page
(inspired by shetzel )
* maybe a delete all button (dangerous i know) on the category management page. would put all quotes to "miscellany."
* replacement of images available for the links row. going to make them like the edit link--clean, simple, editable. will include the psp file.
* batch delete button (according to a checkbox) on the manage page, which means i'll be leaving the search form on that page.
* and I'm going to add the title field (persistence pays off ) to accomodate a wider range of use for this plugin.
* and any bugs that I'm able to track down.

any other minor things that could make it in here?

Status: offline

MrHyde

Forum User
Junior
Registered: 09/11/2003
Posts: 15
Quote by machinari:
* and I'm going to add the title field (persistence pays off ) to accomodate a wider range of use for this plugin.


Yaay.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by Jill: Limiting the search to within one category does not appear to be working...in our installation anyway...hmmm (Just to clarify I'm running dailyquote 1.0.3 with GL1.3.9sr1.)
I tracked your problem Jill, sorry it took so long.
Apparently I changed a variable name in 1.0.3 (don't remember why).

here is the fix.. change lines 61 and 62 of search.php:
just change $_POST['cat'] on both lines to read $_POST['categ']

works for me, hope it works for you.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512

blah blah... i'm ticked now! just realized that many code changes (i think) and at the very least the change log for 1.0.3 to 1.0.4 was never saved and so never made it into the 1.0.4 rc.

the problem was power outages 2 weeks ago. just realized it today after changing a couple things here and there that I'm sure I had already dealt with. So I really don't know what all changes i made to the code because some of them just are not there. if you find stuff not working that worked before.. please let me know so I can reapply changes. sorry.

Jill

Anonymous
I'm getting doubled quotes on the main listings page. See http://www.intotheflame.com/dailyquote/index.php for an example... I get two of each quote listed.

Yep we encountered exactly the same problem and have applied the fixed. No more double entries!

I tracked your problem Jill, sorry it took so long.
Apparently I changed a variable name in 1.0.3 (don't remember why).

No problem at all. I'm sure you have a life away from this plugin. Thanks for looking into it for us. I have applied the fix and the search is now performing as expected. Very cool....thanks Machinari!!!

and I'm going to add the title field (persistence pays off ) to accomodate a wider range of use for this plugin.

Wow...we might just have to join in with MrHyde's celebrations here... We look forward to it with baited breath....

any other minor things that could make it in here?

Well since you're asking (big mistake..lol).....we do have a little tiny suggestion. Since us admins have the ability to use the fabulous new "edit" link which takes us directly to a form to edit an individual quotation...is it possible to improve the display of the editing form for individual quotations? Could the quotation field be changed from a text field to a text box? The current text field makes it quite difficult to edit a long quotation. Most of the darn thing is not actually visible. (We do understand why you've had a text field in the past due to the search producing multiple quotations for editing.) What do you think?

Thanks for all your hard work!

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by Jill:Could the quotation field be changed from a text field to a text box?
It can, most definitely. Good idea and I'm doing it right now.
Quote by Jill:We do understand why you've had a text field in the past due to the search producing multiple quotations for editing.
That is exactly why I did it.

thanks Jill

Jill

Anonymous
excited
COOOOOOL!!!!!

Thanks Machinari....can't wait!!!! This will make a fabulous plugin in even better It's working great on our site and our users already love it.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
DailyQuote 1.0.4 final is released.
See the change log for additions, changes, fixes, etc. Briefly: added the category management page, a utility to check your db for orphaned quotes, and a title field to accomodate a wider range of use. enjoy.

find it at SummitPages.ca.

and a new thread for 1.0.4 here

Chahol

Anonymous
Getting this in my error log. Any ideas?

PHP Formatted Code
sön  5 dec 2004 22.52.36 - Success - Created  table
sön  5 dec 2004 22.52.36 - Inserting default data into dailyquote_settings table
sön  5 dec 2004 22.52.36 - 1064: You have an error in your SQL syntax near '0 , 0, 0, 1, '', 0, '', 0)' at line 1. SQL in question:  
sön  5 dec 2004 22.52.36 - Error inserting default data into dailyquote_settings table
sön  5 dec 2004 22.52.36 - Attempting to unregister the Daily Quote plugin

 

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
that issue has been fixed in the latest release, which is 1.0.4.

see the comments for that error in this thread.

the latest download at summitpages.ca has is the fixed version.

All times are EST. The time is now 01:06 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content