Welcome to Geeklog, Anonymous Sunday, July 21 2024 @ 12:15 am EDT

Geeklog Forums

1.3.10rc1's new theme


Status: offline

LWC

Forum User
Full Member
Registered: 02/19/04
Posts: 818
It looks great, but I think it should have a direct (admin) contact link in the menu per default, like Classic had.

I mean, how do random people suppose to know who to contact?

Classic just gave a link to {site_url}/profiles.php?uid=2.
 Quote

Status: offline

LWC

Forum User
Full Member
Registered: 02/19/04
Posts: 818
Also, I'm not sure if this is a bug or a feature:

[quote from header.thtml]
<?php header ('Content-Type: text/html; charset={charset}'); ?>
[/quote]

Alas, view your source and see there's no charset meta line anywhere in the page.
Is PHP's "header" function suppose to be hidden?

I mean, it does seem to work still, but I just want to be sure.
And if so, why did you choose this over a regular meta, like you did for "robots", etc.?
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 01/12/02
Posts: 13073
Location:Stuttgart, Germany
Quote by LWC: Alas, view your source and see there's no charset meta line anywhere in the page.
Is PHP's "header" function suppose to be hidden?

It's PHP - it's executed on the server and then sent to your browser. Otherwise, you would be able to see Geeklog's source code in your browser ...

Quote by LWC: And if so, why did you choose this over a regular meta, like you did for "robots", etc.?

The meta tags of the "http-equiv" variety were only invented for when you can't send proper HTTP headers. But with PHP, we can - and so we do (now).

Before that, if the server was configured to, say, send .php files with a certain character set, you could end up with two conflicting character set declarations for a page (one from the server's configuration and one from the meta tag). When using the PHP function, that declaration overwrites whatever the server was configured to send, so the ambiguity is gone.

bye, Dirk
 Quote

Status: offline

LWC

Forum User
Full Member
Registered: 02/19/04
Posts: 818
Ok, so it's a feature.

And what about the contact link? What do you think? I hope you see how important it is.
 Quote

Status: offline

vinny

Site Admin
Admin
Registered: 06/24/02
Posts: 352
Location:Colorado, USA
Quote by LWC:And what about the contact link? What do you think? I hope you see how important it is.


Whether or not Dirk chooses to add the contact link to the distribution, it is trivial to add such a link to the themes header template file. As for geeklog.net, I'm not sure that it makes sense to have such a contact link. There is no one "contact" email address, and plenty of other ways to contact site moderators/admins.

-Vinny
 Quote

All times are EDT. The time is now 12:15 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content