Welcome to Geeklog Wednesday, October 18 2017 @ 12:46 pm EDT


Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
Sorry for my absence, my wife and I were on vacation for a week. But now I'm back, recharged, and ready to complain!!! (Not really, hopefully it's more useful than that.)

1) In templates/centerblock.thtml would you consider adding class="content" to the tag? It makes the quote appear in basically the same font as article summaries. Not a big deal, but I noticed that the default font used doesn't seem to be anywhere else on my entire webpage. I'm OK with the speaker and contrib lines being in different fonts, since I'm not sure what else they'd look better as.

2) Thanks for fixing your tarball. It works like a charm now. I forgot to mention that last time.

3) Your upgrade sql patch does not include the 'whatsnew' column, it includes a 'test' column, which I assume is unused.

4) Why doesn't a submitted quote appear in the "Submissions" page of the admin block? I know where to find them (under "Manage Quotes" for privledged users), but is it possible using the plugin API to have it added to the submissions page, too? It's nice for admins who enable their submission queues to have only one place to check for articles, events, links, quotes, etc...

5) Thanks for the "What's New" functionality. Now my users don't have to wait potentially weeks to see the fruits of their labor. I know some admins would like to keep new quotes a surprise, and that's great, too. I like options.

There are a couple of other things I'm tracking right now, but I'd like a little more time to pin them down to exact causes. If I can't solve them the least I can do is tell you exactly what's happening.

I think you're very close to a 1.0 release. I'm not the kind of guy who likes to sit on beta versions forever, though, so I'm biased. I think at this point, you've got a very solid code base which works as advertised. I've never come across any "showstopper" bugs (except during install), and you've been extremely responsive to bugs and suggestions.

By the way, I don't cache my quotes, so I really have no feedback for you on your previous query. I'm totally random.

-Shane

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by shetzel:1) In templates/centerblock.thtml would you consider adding class="content" to the tag? It makes the quote appear in basically the same font as article summaries. Not a big deal, but I noticed that the default font used doesn't seem to be anywhere else on my entire webpage. I'm OK with the speaker and contrib lines being in different fonts, since I'm not sure what else they'd look better as.
seems to me that I didn't specify a particular font for either the quote or byline. they both will take on the site's default font or else the browser's default font. beyond that, it is pretty easy to customize so I think I'll leave that one. the only diff between the quote and the byline is the "em" tag.
Quote by shetzel:3) Your upgrade sql patch does not include the 'whatsnew' column, it includes a 'test' column, which I assume is unused.
oops. just replace 'test' with 'whatsnew'. cant believe i left that in there.
Quote by shetzel:4) Why doesn't a submitted quote appear in the "Submissions" page of the admin block?
without getting it in front of me just now, I'd have to say it is simply because I didn't use the GL functions for this feature, but rather used my own. I'll look into that.

thanks for the feedback!

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
here is a bug that i'm surprised hasn't bothered anyone yet:
Quote by frawo: Thank you for a nice plugin (it looks good on others sites), but I get this error:
parse error, unexpected T_IF in /faunogfiskarlaget.net/dailyquote/add.php on line 205
Why?

go to line 204 of add.php and simply put a semi-colon at the end of the line.
change this:
PHP Formatted Code
$retval = "<p align="center" style="font-weight: bold; color: red;">"
 
to this:
PHP Formatted Code
$retval = "<p align="center" style="font-weight: bold; color: red;">";
 


thanks to frawo who posted at summitpages.ca with this bug report.

Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
How long has it been like that? Admittedly, I haven't added a new quote with the new version yet.

OK, here's subtler issue #1.

1) Double quotation marks in the quotes. I know, weird, but it happens. Some very interesting things occur. First, obviously, the quote looks odd, since it has the encapsulating quotation marks around the whole thing. Second, it seems to work just fine everywhere except the management page. When you try to edit the quote, it cuts it off at the first mark in the text box.

So how do we handle it? Do we manually prevent double quotation marks from being present when we moderate the submissions? Or would we want to convert all double quotes to single quotes? Admittedly, I don't have a real strong opinion, but I thought you mightlike to know.

-Shane

Status: offline

ppmnt

Forum User
Chatty
Registered: 09/06/2004
Posts: 53
Sorry I haven't replied yet, I have not had a chance to try it. I should get to it this weekend.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by shetzel: How long has it been like that?
crept in at 0.9.2.1 so recently.
Quote by shetzelBig Grinouble quotation marks in the quotes. I know, weird, but it happens.
Well, on the batch add page the instructions say not to enclose quotations in double quotes, but, obviously, I neglected those instructions on the single add page. still doesn't solve our problem tho does it?
Quote by shetzel:So how do we handle it? Do we manually prevent double quotation marks from being present when we moderate the submissions? Or would we want to convert all double quotes to single quotes?
converting the double quotes to single quotes automatically isn't going to fix the problem. Simply because we are going to deal with people who cant distinguish properly between a regular quotation and a quotation within a quotation. and then, if you have alot of traffic, moderating everybody's punctuation can also be a pain.

maybe a regex that converts all inner double quotes to single quotes and removes any encapsulating double quotes. I say "remove" because the logic adds double quotes automatically.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
the documentation for this plugin includes the install doc as well as some basic instructions and "how to's." It will be included with the 1.0 release this weekend. It's time for midterms so I have a bit of time in the next few days to do this. no exams for the teacher

I've decided not to include a category management page until a later release. not to worry shetzel, it'll be done by Christmas so you can turn those Xmas quotes on and those halloween quotes off.

I'll also check for 1.3.10 compatablilty. I haven't checked yet if there will be any issues. there shouldn't be.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512

DailyQuote 1.0 is Released!
It is FuLLy FunctionaL

Get it here! It is also awaiting approval here at geeklog.net and so then you will be able to find it here as well.

documentatoin is included. changes from the last beta involve a few permission errors for add.php, centerblock, and what's new. Fixed a few typos and a message or two. Also fixed the quotation mark issue in GET--depends on your perspective i guess.

Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
Super. I'll install it today and start playing with it.

Thanks for addressing the quotation mark issue. If your final solution is anything like you described above, that would be a good solution for a thorny problem. I don't know if there is an ideal solution, either.

And not to worry about the categories; it's a wishlist feature totally separate from the core functionality. I'll expect it when it's done.

Thanks for all your work. Does this mean we have to start a new thread?

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by jasonhackwith: I've installed the plugin at http://www.intotheflame.com/, and everything appears to be working correctly except for one thing: deleting a user submitted quote from the moderation queue.

Upon clicking on "delete," I get a SQL error:

Tue Oct 26 12:23:06 2004 - 1064: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE itf_dailyquote_quotes.ID=394 LIMIT 1' at line 1. SQL in question: DELETE itf_dailyquote_quotes WHERE itf_dailyquote_quotes.ID=394 LIMIT 1

If I hit "approve," I can then go find it and delete it, but I can't delete it directly out of the submission queue.

Otherwise, everything is fantastic. I have 394 quotes in the system already and more going... ultimately I'll be putting in at least a few thousand more.

My apologies... in rewriting the mySQL statements to be 3.23 compatable, I neglected the addition of a single word, "FROM."

in moderation.php on line 195, change
PHP Formatted Code
    if (!DB_query("DELETE {$_DQ_TABLES['dailyquote_quotes']} WHERE {$_DQ_TABLES['dailyquote_quotes']}.ID=$qid LIMIT 1")){

 
to this:
PHP Formatted Code
    if (!DB_query("DELETE FROM {$_DQ_TABLES['dailyquote_quotes']} WHERE {$_DQ_TABLES['dailyquote_quotes']}.ID=$qid LIMIT 1")){

 
and on line 202, change
PHP Formatted Code
    if (!DB_query("DELETE {$_DQ_TABLES['dailyquote_lookup']} WHERE {$_DQ_TABLES['dailyquote_lookup']}.QID=$qid")){

 
to this:
PHP Formatted Code
    if (!DB_query("DELETE FROM {$_DQ_TABLES['dailyquote_lookup']} WHERE {$_DQ_TABLES['dailyquote_lookup']}.QID=$qid")){

 

thanks for the report.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
I've noticed a few of you have this plugin operating in other languages. that's awesome work! If you like, I would be glad to include your language file in the tarball. just shoot it to my email.

I'm sure others would love to benefit from your work and would appreciate you for it.

Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
Would you consider making the following addition to the code for those of us who display the contributor name in the block? It brings the code in line with the centerblock code, which you already have this way.

functions.inc, line 671, original:
PHP Formatted Code
                if (!$dbquote = DB_query("SELECT Quotes, Quoted FROM {$_DQ_TABLES['dailyquote_quotes']} WHERE Status='1' ORDER BY rand() LIMIT 1")){
                    $retval .= $LANG_DAILYQUOTE['randomerror'];
                    COM_errorLog("An error occured while retrieving your quote",1);
                } else {
                    list ($Quotes, $Quoted) = DB_fetchArray($dbquote);
                    if (!empty($Quotes)){
                        $retval = "<p align="left">"";
                        $retval .= $Quotes;
                        $retval .= "
"</p>" . LB;
                        $retval .= "<p align="right"><em>";
                        $retval .= $Quoted;
                        $retval .= "</em></p>";
                    }
                }

 


functions.inc, line 671, new:
PHP Formatted Code

                if (!$dbquote = DB_query("SELECT Quotes, Quoted, q.UID, username FROM {$_DQ_TABLES['dailyquote_quotes']} q, {$_TABLES['users']} gl WHERE Status='1' AND q.UID=gl.uid ORDER BY rand() LIMIT 1")){
                    $retval .= $LANG_DAILYQUOTE['randomerror'];
                    COM_errorLog("An error occured while retrieving your quote",1);
                } else {
                    list ($Quotes, $Quoted, $uid, $username) = DB_fetchArray($dbquote);
                    if (!empty($Quotes)){
                        $retval = "<p align="left">"";
                        $retval .= $Quotes;
                        $retval .= "
"</p>" . LB;
                        $retval .= "<p align="right"><em>";
                        $retval .= $Quoted;
                        $retval .= "</em></p>";
//                        $retval .= "<p style="text-align: right; font-size: 8pt;">";
//                        $retval .= $LANG_DAILYQUOTE['subm_by'] . " " . $username;
//                        $retval .= "</p>";
                    }
                }


 


Thanks for your consideration. Notice that the actual display code is commented out, just like in the centerblock's thtml file.

Otherwise, 1.0 looks good so far. It'll be put through a few paces over the next couple days.

Status: offline

MrHyde

Forum User
Junior
Registered: 09/11/2003
Posts: 15
excited
Thanks a lot for this plugin. Its something that I've wanted for a long long time. So far, I've been using the Random Quote Block that used the gl_quote database, but it lacked the add/delete functionality, which meant I had to use phpMyAdmin to make changes. So, from what I've read so far, this plugin satisfies most of my requirements. I'll go home and try and install it tonight to see how it works.

Thanks once again for all the work you and other testers have done on this plugin.

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by MrHyde:I'll go home and try and install it tonight to see how it works.

You may want this update before you install what you have, MrHyde--a few fixes in the update.

DailyQuote 1.0.2 is just a few minor fixes and an feature request update. find it here. It isn't on Geeklog.net yet cuz I have no idea how to upload a file to replace the one that is there (no form field for replacement file). any hints?

Quote by shetzel:Would you consider making the following addition to the code for those of us who display the contributor name in the block? It brings the code in line with the centerblock code, which you already have this way.

I added that functionality for you shetzel though there was a bit more involved than those few lines. Perhaps sometime later I will throw those settings in the configuration page. At that time, I'll also throw an add link in the block that can be turned on or off from settings.

As with the centerblock, you have only to uncomment the code to gain a contributor's by-line in the phpblock. Details in the change.log. Along with a few other minor fixes, this one now works.

Status: offline

MrHyde

Forum User
Junior
Registered: 09/11/2003
Posts: 15
thoughtful
I've installed DailyQuote 1.0.2 and did not have any major problems. I've had a quick play around with it and have a few comments.

1) Installation Documentation. Very good and is it was straightforward. The only place I got slightly confused is at Section 3.3.2 - " Did you get a successful completion message that your database tables have been created." I got a message saying Installation successful. It didn't say anything about database tables being created. That sort of confused me as it gave me the impression that something was wrong since I did not get a message that databases were created.

2) The other place that confused me was " There should now be a DailyQuote link in your top header." Which top header are you talking about? Is it the one with the links to Homepage • Gallery • Get Published • Links • Calendar • Personalize • Polls • Search • Site Stats. If so, I don't have a Daily Quote link there even after refreshing numerous times. I did have the DailyQuote link in the Admin block and managed to configure it from there. I found the link to the manage quotes page from the admin block and after adding a few sample quotes, the Quote of the Day header showed up at the top.

Now for the suggestions.
1) I would like the heading "Quote of the Day" to be user configurable. I want to call it Random Thoughts.

2) Also, can the category be used as a sort of heading. Best would be a different column for "Title". Have a look at my current random thought block at my website - Crazyguy to see what I mean. You might have to reload a couple of times to hit a quote with a title.

3) Is it possible to have the author google linked. Again, have a look at my site for examples.

I believe all of these, especially 2&3 are easily implemented by changing some .php file, but I do not know which one? If you dont think it is useful enough for others, please tell me which file to edit and I'll add it to my deployed version.

Thank you for all the work done in this plugin.

Cheers,
MrHyde

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
Quote by MrHyde:
1)...I got a message saying Installation successful. It didn't say anything about database tables being created.

For those who actually attempt to verify a successful install, the message about successfully creating tables is found in the error log--excuse the ambiguity.
Quote by MrHyde:
2) The other place that confused me was " There should now be a DailyQuote link in your top header."... ...If so, I don't have a Daily Quote link there even after refreshing numerous times.

perhaps your browser was loading a cached page? the link should have showed up at the 1st refresh. There is nothing set up that would make that link appear only after quotations have been added.
Quote by MrHyde:
1) I would like the heading "Quote of the Day" to be user configurable. I want to call it Random Thoughts.

This can be changed in /plugins/dailyquote/language/english.php
edit: unless you are refering to the block title used in a phpblock. that can be defined in admin->blocks--the same place where you would enable or disable the block..
Quote by MrHyde:
2) Also, can the category be used as a sort of heading....
3) Is it possible to have the author google linked. Again, have a look at my site for examples.

not sure what you are asking for exactly. if you could fix your website link I'll be glad to take a look. and I don't know what it means to be "goggle linked."

Status: offline

shetzel

Forum User
Chatty
Registered: 19/03/2004
Posts: 39
by machinari:] I added that functionality for you shetzel though there was a bit more involved than those few lines.

Darn it! I forgot about the cached quotes. It's one of those shameful cases where I tested what I used. I also noticed you did a couple consistiency clean-up where it makes the code a better read. All in all, it's looking tight. Thanks.

Status: offline

MrHyde

Forum User
Junior
Registered: 09/11/2003
Posts: 15
embarrassed
Quote by machinari:
Quote by MrHyde:
2) Also, can the category be used as a sort of heading....
3) Is it possible to have the author google linked. Again, have a look at my site for examples.

not sure what you are asking for exactly. if you could fix your website link I'll be glad to take a look. and I don't know what it means to be "goggle linked."


Hmm... the A HREF didn't work. Anyway, my website address is http://www.crazyguy.org

Status: offline

machinari

Forum User
Full Member
Registered: 22/03/2004
Posts: 1512
MrHyde, thanks for your input. here are my conclusions after a bit of thought.

well, I still don't know what a google link is. but in thinking about this, I decided to make the contributor's name (which was just added to the centerblock and phpblock) a link to the search page which would display all submissions by that contributor--just like it is now with the contributor's name in the GL search results.

The category as heading presents a couple of probs, not the least of which to how I cache the quote; and then there is the multiple category issue.. The code is easy--it would just mean a bunch of changes to the DB and some additional SELECTs.

How bout this? ... what if I included all the info that makes it into the regular display of a quote, like the contributor and the byline and the categories, etc., and leave a section in the settings that would allow you to include whatever pieces you wanted (would only apply to the centerblock and/or the phpblock)? then you would have only to modify your own HTML output so that it would display however you like--as a category line underneath, beside, or as a heading on top.

This would definitely be a fluff feature. If I do this, It wont be for a bit.

Status: offline

MrHyde

Forum User
Junior
Registered: 09/11/2003
Posts: 15
Quote by machinari:
well, I still don't know what a google link is. but in thinking about this, I decided to make the contributor's name (which was just added to the centerblock and phpblock) a link to the search page which would display all submissions by that contributor--just like it is now with the contributor's name in the GL search results.


A google link on the author is simply pointing to the google search for that author. For example, if the author of one of the quotes is Sigmund Freud, the google link will be something like http://www.google.com.au/search?hl=en&q=Sigmund+Freud&btnG=Search&meta=. This then allows the users to simply click on the name of the author to find out more information on that author.

Quote by machinari:The category as heading presents a couple of probs, not the least of which to how I cache the quote; and then there is the multiple category issue.. The code is easy--it would just mean a bunch of changes to the DB and some additional SELECTs.

Fair enough.. I can see how that can cause problems.

Quote by machinari:
How bout this? ... what if I included all the info that makes it into the regular display of a quote, like the contributor and the byline and the categories, etc., and leave a section in the settings that would allow you to include whatever pieces you wanted (would only apply to the centerblock and/or the phpblock)? then you would have only to modify your own HTML output so that it would display however you like--as a category line underneath, beside, or as a heading on top.

This would definitely be a fluff feature. If I do this, It wont be for a bit.

Thanks. I don't mind if it takes time to do this.

Cheers,
MrHyde

All times are EDT. The time is now 12:46 pm.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content