Welcome to Geeklog Sunday, October 22 2017 @ 10:27 pm EDT


Status: offline

remy

Forum User
Full Member
Registered: 09/06/2003
Posts: 141
Location:Rotterdam & Bonn
Quote by Turias: When I go to someone's profile, and click on "Find all postings by [user]", why are so many links returned in the results section? This is a bug that has been in there since at least 2.2RC1.

Turias, that bugs me too but is not a forum bug. I just make a call to the search class API.


Actually, this bug is filed with the solution. There was no answer yet.
The problem is caused because links do not have a uid, so you could not search for 'a link posted by....'.

Status: offline

Turias

Forum User
Full Member
Registered: 20/10/2003
Posts: 807
Quote by remy:Actually, this bug is filed with the solution. There was no answer yet.
The problem is caused because links do not have a uid, so you could not search for 'a link posted by....'.


Actually, that's not entirely true. In the database, each link contains the field "owner_id". On my site, probably since I allow all link submissions to go through without moderation, all of the owner_id fields are valid. So, technically I could do a search for all links posted by ____.

Or at least owned by _____, which would be better than always returning all of them.

Status: offline

remy

Forum User
Full Member
Registered: 09/06/2003
Posts: 141
Location:Rotterdam & Bonn
Well, you're right. But it is not done that way in standard geeklog.

Anyway, there's another issue with the forum.
I've deleted an user, and he came back with the same name.
The forum still mentiones the username, but can't show a profile anymore. Annoying.

Status: offline

Turias

Forum User
Full Member
Registered: 20/10/2003
Posts: 807
That reminds me of another forum issue I had in the past. Blaine, have you changed the forum database structure so that moderators are referenced by uid instead of username? I ran into a problem before where if I changed the username of a current moderator, that person would lose all moderation privileges since the username was hardcoded into the database instead of the uid.

Status: offline

Blaine

Forum User
Full Member
Registered: 16/07/2002
Posts: 1233
Location:Canada
Quote by remy: I've deleted an user, and he came back with the same name.
The forum still mentiones the username, but can't show a profile anymore. Annoying.

What are you expecting, the forum to figure out the new user is the same person as the previous (deleted) username and connect any old references to that user to the new user profile

Granted, I can add logic to disable the profile lookup if the UID is no longer on file. Testing on by 2.3 release, this situation does not generate any errors but does bounce you out to the main index.php. This may require yet another database query per post as I display the page to check for valid on-file UID's. I've been trying to improve performance - albeit not at the risk of effecting functionality.

Geeklog components by PortalParts -- www.portalparts.com

Status: offline

Blaine

Forum User
Full Member
Registered: 16/07/2002
Posts: 1233
Location:Canada
Quote by Turias: That reminds me of another forum issue I had in the past. Blaine, have you changed the forum database structure so that moderators are referenced by uid instead of username? I ran into a problem before where if I changed the username of a current moderator, that person would lose all moderation privileges since the username was hardcoded into the database instead of the uid.


Thanks for reminding me, I had that one on my list for the 2.3 release. Yep - will take care of that.
Geeklog components by PortalParts -- www.portalparts.com

FreakWorld

Anonymous
Will I got all my Themes links and forum art all updated. I emailed you on some stuff. But I guess I better put them here so you just have 1 place for everyone's problems and changes. hehehehe

STORY TO FORUM MIGRATION UTILITY-
It needs to be added to the style.css

/forum/javascript/mainheader.js-
There is an error somewhere calling for this.
It dues not show up in the normal error log. I have a program that tills me every paged that was called and not received.

htdocs/layout/Freak_World/forum/forumstyle.css-
Something is calling for the forumstyle.css. In the plug in it has been put here.
htdocs/layout/Freak_World/forum/layout/forumstyle.css
This is also not showing in the GL error but in my program.



Request:
1.I like to have a PM button on post. I see that you took out the PM program on the forums totally.
But maybe set it up like an email profile page. Also add in Admin to ask if Chatbox is installed. That way it knows to request.

2.Make it were the Avatar Image is not changing the size of the Avatar Image. I want to see this override the GL settings also. That way there is 1 easy place to set the size.

3. I will like to see the new messenger and Location in the Member Profile also.

4. heheh something just for me. I want to let people put an Image in the Signature. As I think you know.
I am more or less a gamming site. And gamers (kids) like to have Signature Images. Can you put an upload
in the forum Prefs for this. I suggest that it has a limit in the Admin that don't change the size. And
I do understand that some people may not want this on there site. So you may want to put in the
Admin a way to turn it off.

5. Can you make it were Signatures can be center. Make it an option in the Members forum prefs.
(The Signature Image to if I can con you into it. hehehehehe)

6. Can you make it were Mood pics display across the top of the New Topic/Reply submit page.
I do understand that this will make it were you can only have so many pics. So I suggest keeping the dropdown box for extras. People just don't seam to use the Dropdown much. I think it's because they don't see the pic.

7. Can you add a new row in the Topic Subject page were you can see the Mood pic.

8 Can you rename the Mark all topics Read to Mark this Category Read. With that. I also will like to see a Mark all Read for the hole site. And in each forum. A Mark this Topic Read for that forum alone.

9. The forum_outline_footer & forum_outline_header will not line up anymore. What I mean is for themes that
you want to put the forums in a box. 2.2 you was able to do that. But it is not doing it now.
It great for Themes like gameserver.

Thanks Blaine!

P.S. I need a plug in made that I don't know how to do.
When you got time. Can you email me. I will send you the info and you can till me how much it will cost to get it made. The plug in I want is going to take a bet of time. Thats why I will wate till you get 2.3 all fixed up the way you want it. hehehehehe

Status: offline

Blaine

Forum User
Full Member
Registered: 16/07/2002
Posts: 1233
Location:Canada
FreakWorld,

Thanks for the information on the Javascript and CSS. These are some remains from my overhall that I've been doing - they are now fixed.

With respect to your list:

1) I will be removing the PM functionality from the next release. The current PM functionality was a temporary hack. I won't be distributing the update with this hack in place. Chatterblock was never meant to be a Private messenger component.

2) I have a few new ideas for the avatar support but it will continue to use the Geeklog Profile image.

3) I have been working on a new Private Messenger. This will be offered as an integrated component for GL and Forum but I'm not ready to discuss when or how at this time. There is more work required and I want to get this version of Forum completed first.

4 - 5) If you need custom features - please contact me for an estimate. I likely won't be allowing this as a general feature for security reasons.

6) Not sure I agree. I'm trying to keep the user interface as clean as I can.

7) Sounds like you should be able to do this by altering the template file.

8) You can change any of the displayed text in the language file. I think for the number of users that actually use the Mark Read feature - what I have is sufficient. I can be persuaded to add these other options but it would clutter up the index page even more and I'd have to be convinced users really want this.

9) The Forum_outline_header and footer templates for 2.3 create a table that when I set border=1 they appear fine. I've removed the images from this outline. Your welcome to add it back in - thats up to you and your theming. I'm providing you that option.

Thanks again for your ideas and constructive feedback.


Geeklog components by PortalParts -- www.portalparts.com

FreakWorld

Anonymous
found a problum.
When you get an email from the forums tilling you someone has posted.
The url is wrong.
I don't know if someone had noticed that. But let me show you what I mean.

The email sent me this.
PHP Formatted Code
http://www.freakygamers.net/forum/viewtopic.php?forum=3&showtopic=848&lastpost=truen
 


But the real url is........
http://www.freakygamers.net/forum/viewtopic.php?forum=3&showtopic=848&lastpost=truen

If you see it's adding a slash and even if it was a good slash it backwords.lol

FreakWorld

Anonymous
ok I can't get it to show on here.
But were it has 848. Just after it it's puting a backwords slash.

Status: offline

destr0yr

Forum User
Full Member
Registered: 06/07/2002
Posts: 324
Quote by FreakWorld:
PHP Formatted Code
http://www.freakygamers.net/forum/viewtopic.php?forum=3&showtopic=848&lastpost=truen


 



Open and edit geeklogdir/plugins/forum/language/english.php, change line 236 (ish) to read:
PHP Formatted Code

$LANG_GF02['msg23b']   = "A new topic '%s' has been posted by %s in the %s's forums on the %s website.\nYou may view it at: %s/forum/viewtopic.php?forum=%s&showtopic=%s\n";

 

-- destr0yr "I love deadlines. I like the whooshing sound they make as they fly by." -- Douglas Adams

Status: offline

destr0yr

Forum User
Full Member
Registered: 06/07/2002
Posts: 324
Blaine,

Another thing I just noticed when replying to freaky in the previous post. When using CODE, i had "backslashn" and clicked submit, forum kept the backshashes in the post. If you preview, then submit, the backslashes are omitted in the final post. hope that makes sense.
-- destr0yr "I love deadlines. I like the whooshing sound they make as they fly by." -- Douglas Adams

FreakWorld

Anonymous
the code you just put reads just like what I already have in there.

FreakWorld

Anonymous
But that was wrong also.
But I did find it.

Go just from 23b to 23c.
there is the slash.

PHP Formatted Code
$LANG_GF02['msg23c']   = "\nYou may view it at: %s/forum/viewtopic.php?forum=%s&showtopic=%s\&lastpost=truen";
 

it needs to be changed to
PHP Formatted Code
$LANG_GF02['msg23c']   = "\nYou may view it at: %s/forum/viewtopic.php?forum=%s&showtopic=%s&lastpost=truen";
 


Some one comfer this for me. It's not like I know what I am doing. lol

FreakWorld

Anonymous
yep I just tested it and it works now. Just take out that slash

Status: offline

remy

Forum User
Full Member
Registered: 09/06/2003
Posts: 141
Location:Rotterdam & Bonn
Quote by Blaine: I've deleted an user, and he came back with the same name.
The forum still mentiones the username, but can't show a profile anymore. Annoying.

What are you expecting, the forum to figure out the new user is the same person as the previous (deleted) username and connect any old references to that user to the new user profile

Granted, I can add logic to disable the profile lookup if the UID is no longer on file. Testing on by 2.3 release, this situation does not generate any errors but does bounce you out to the main index.php. This may require yet another database query per post as I display the page to check for valid on-file UID's. I've been trying to improve performance - albeit not at the risk of effecting functionality.


Somewhere in the geeklog dialogues, text is mentioning 'when you delete an user, all posts will NOT be deleted. However they will show up as Anonymous'. This refers to articles, polls, comments etc. Shouldn't it refer to the forum as well? So, have the uid set to 1 at user delete (PLG_userdelete_forum) ?


Status: offline

Turias

Forum User
Full Member
Registered: 20/10/2003
Posts: 807
Here's a request for future forum versions:

Once a thread is locked, I don't think people should be allowed to edit their posts. The thread is locked, and no one should be able to modify it. I have had users continue conversations in locked threads by editing their posts. .

Status: offline

Turias

Forum User
Full Member
Registered: 20/10/2003
Posts: 807
Well, if you're interested, I added some of the functionality myself. In gf_showtopic.php, I added the following where $editlink is normally calculated:

PHP Formatted Code
if ($showtopic['pid'] == 0) {
    $replytopicid = $showtopic['id'];
} else {
    $replytopicid = $showtopic['pid'];
}

if ($mode != 'preview' && ($_USER['uid'] > 1) && ($_USER['uid'] == $showtopic['uid']) &&
(DB_getItem($_TABLES['gf_topic'],"locked","id=" . $replytopicid) != 1)) {
    $editlink = '<a href="createtopic.php?method=edit&forum='.$showtopic['forum']. '&id=' .$showtopic['id']. '&editid=' .$showtopic['id']. '"><img src="' .$imgset.'/modify.gif" border="0"></a>';
}
else{
    $editlink = "";
}
 


It's quick and dirty, but works in removing the edit link in locked topics. The major problem is that people can still edit if they manually enter the correct URL.

Status: offline

Turias

Forum User
Full Member
Registered: 20/10/2003
Posts: 807
I found a better way to do it. Scrap the last idea and instead change the following in forum/createtopic.php:

PHP Formatted Code
// NEW TOPIC OR REPLY
if(($method == 'newtopic' || $method == 'postreply' || $method == 'edit') OR ($preview == "Preview")) {
    // Changed  to not allow users to edit posts in locked topics.
    $pid = 0;
    if ($method == 'edit') {
        $query = DB_query("SELECT pid FROM {$_TABLES['gf_topic']} WHERE id=$id");
        $S = DB_fetchArray($query);
        $pid = $S['pid'];
    }
    if (($method == 'postreply' && DB_getItem($_TABLES['gf_topic'],"locked","id=$id") == 1) ||
        ($method == 'edit' && (DB_getItem($_TABLES['gf_topic'],"locked","id=$pid") == 1 ||
                               DB_getItem($_TABLES['gf_topic'],"locked","id=$id")))) {
...
 


Unfortunately, it requires an extra database query, but it seemed to be the only way to get the id for the entire topic. I could have passed it in via the "Edit" link, but again, someone could then modify just that number in the link to circumvent the permissions check.

Whoosh!

Anonymous
I notice the forum here is different than the forum I downloaded.

How do I get the update?

All times are EDT. The time is now 10:27 pm.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content