Subject: comment function of Gl 1.6.0b1

Posted on: 03/05/09 09:37am
By: 1000ideen

Can anybody explain the new comment function of Gl 1.6.0b1 ?
http://www.geeklog.net/docs/english/config.html#users_comments

How can I turn off the comment_edittime? I want comments to be edited eternally.

How can I turn off the article_comment_close_days? I don`t want to close stories for comments.

Re: comment function of Gl 1.6.0b1

Posted on: 03/05/09 01:27pm
By: LWC

If you can already name parameters, you can guess they're right in the configuration's GUI, as new settings in the comments' section.

Re: comment function of Gl 1.6.0b1

Posted on: 03/05/09 01:32pm
By: 1000ideen

There is no turn off checkbox for article_comment_close_days. Is the parameter 0 ? and what about comment_edittime?

Re: comment function of Gl 1.6.0b1

Posted on: 03/05/09 03:32pm
By: LWC

Now you're on to something. I can only assume it's 0 for both. Otherwise 0 would stand for the same thing as comment_edit=0 in general.

You should put 0, comment on something and 25 hours later report here if it's still editable.

P.S.
The more important issue to debate is the comment notifications. Read my comments [story:geeklog-1.6.0b1#comments for the article].

Re: comment function of Gl 1.6.0b1

Posted on: 03/05/09 07:58pm
By: 1000ideen

http://wiki.geeklog.net/index.php/SoC_improving_comments_2008
I thought when I say 1 day for commenting then a MySQL command would close all stories for commenting older than 1 day. But nothing happens. Probably it will only do that with future stories? That would not make much sense.

Ops, now it happened... All comments but the one of the featured story have been closed with days 0. So days 0 does not turn article_comment_close_days off but sets it to 0.
Repeating my question: How do I turn off ?
Acording to the wiki page above it was meant as an option and not compulsory.

--> Another problem, I set it to 100 days now but the comments stay closed. Is this a bug or a feature or do I have to wait 100 days?
Could I please have the manual MySQL command to open all stories for comments again?


Just thinking: Would be nice to have a dash board where I could mass close and also mass open stories for commenting e.g. older than or younger than X days.

Personally I won`t need this feature anyway (that`s why I want to turn it off) because I think that it is a typical feature request of frustrated Wordpress users drowning in spam comments.

Re: comment function of Gl 1.6.0b1

Posted on: 05/05/09 07:24pm
By: 1000ideen

I turned this into 2 bug reports:
http://project.geeklog.net/tracking/view.php?id=876
http://project.geeklog.net/tracking/view.php?id=875

Still investigating comment_edittime as nobody answers my question:

How can I turn off the comment_edittime?

Re: comment function of Gl 1.6.0b1

Posted on: 05/05/09 08:22pm
By: 1000ideen

Comment edit time cannot be turned off.
http://project.geeklog.net/tracking/view.php?id=878

Re: comment function of Gl 1.6.0b1

Posted on: 06/05/09 08:25am
By: 1000ideen

Now I want to test turning off "Number of most recent stories enabled for comments" but all my comments are closed Cry

Could I please have the MySQL command to open all stories for comments again?

Re: comment function of Gl 1.6.0b1

Posted on: 12/05/09 10:30am
By: 1000ideen

Quote by: 1000ideen


Could I please have the MySQL command to open all stories for comments again?


Re: comment function of Gl 1.6.0b1

Posted on: 13/05/09 05:09pm
By: suprsidr

something along the lines of
PHP Formatted Code
DB_query( "UPDATE {$_TABLES['stories']} SET commentcode  = 0 WHERE commentcode = -1" );

I think.

-s

Re: comment function of Gl 1.6.0b1

Posted on: 13/05/09 05:59pm
By: 1000ideen

I`m beginning to understand the system. This is the direct SQL input in phpMyAdmin:

UPDATE gl_stories SET commentcode = 0

Re: comment function of Gl 1.6.0b1

Posted on: 12/10/09 06:29am
By: LWC

Actually Dirk wrote in the bug tracker that it's
PHP Formatted Code
UPDATE gl_stories SET commentcode = 0, comment_expire = 0 WHERE commentcode = 1;

But what about stories that are already open (commentcode=1) but only until year X (which is the manual fix for now)? Which line would need to be run for them after the fixed version 1.6.1 comes out?
Would it be (in a combined fix)
PHP Formatted Code
UPDATE gl_stories SET commentcode = 1, comment_expire = 0 WHERE comment_expire > 0;

?

Re: comment function of Gl 1.6.0b1

Posted on: 23/11/09 06:50am
By: LWC

Oops, "already open" is 0, not 1 (closed comments) and ">0" is not something comment_expire can be compared against. So if you also want to fix previously indirectly manually fixed comments (where comments were manually opened years into the future to delay the bug), the code should be:
PHP Formatted Code

UPDATE gl_stories SET commentcode = 0, comment_expire = 0 WHERE commentcode = 1;
UPDATE gl_stories SET comment_expire = 0 WHERE comment_expire > '0000-00-00 00:00:00' AND commentcode = 0;
 

A combined fix could be:
PHP Formatted Code
UPDATE gl_stories SET commentcode = 0, comment_expire = 0 WHERE comment_expire > '0000-00-00 00:00:00' AND commentcode > -1;

But in the end, I would even add:
PHP Formatted Code
UPDATE gl_stories SET comment_expire = 0 WHERE comment_expire > '0000-00-00 00:00:00';

I now see why it can't be included in the official changelist - it would allow comments that actually need to be expired. But those who used the new expire function before it was fixed are probably better off resetting it anyway.

Re: comment function of Gl 1.6.0b1

Posted on: 23/11/09 07:23am
By: ::Ben


PHP Formatted Code

UPDATE gl_stories SET commentcode = 0, comment_expire = 0 WHERE commentcode = 1;
UPDATE gl_stories SET comment_expire = 0 WHERE comment_expire > '0000-00-00 00:00:00' AND commentcode = 0;
 


:shakehands: Thank you for this.

::Ben

Geeklog - Forum
https://www.geeklog.net/forum/viewtopic.php?showtopic=87268