Subject: Geeklog 1.5.1 and advanced editor

Posted on: 26/09/08 12:17pm
By: ::Ben

Hi,

Can someone tell me if he is able to add pictures with advanced editor in a story on a Geeklog 1.5.1?

For static page it is OK

::Ben


Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 04:54am
By: ::Ben

Hello,

Sorry I still can add any picture on the demo.geeklog.net with advenced editor in a story. Tested with FF and IE.

I don't think it is a security issue because I can add images in a static page.

Please, can someone check it?

Thanks.

::Ben




Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 02:04pm
By: Anonymous

Not to interfere, but why do non admin users get the plaintext editor by default, whereas the admins get the advanced editor by default?

Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 04:03pm
By: Anonymous

Quote by: Guest

Not to interfere, but why do non admin users get the plaintext editor by default, whereas the admins get the advanced editor by default?



Is this something that everyone would like? I can certainly change the default to be html instead of plain. As for the FCKeditor being a default with no login, I see that as a potential security problem. For non-Admin's with regular login access, I purposely did not include that as an option, because this is a demo site and you would know what the features are when logging in as an Admin.

Michael



Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 04:28pm
By: Anonymous

Quote by: cordiste

Hello,

Sorry I still can add any picture on the demo.geeklog.net with advenced editor in a story. Tested with FF and IE.

I don't think it is a security issue because I can add images in a static page.

Please, can someone check it?

Thanks.

::Ben



Ben,

Are you trying to disable that feature? I have it set to work on the demo site.

Michael

Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 05:41pm
By: ::Ben

Hi Michael,

My question is are you able to add a picture to a story with advanced editor on the demo.geeklog.net?

Because I can't. Seems to be a big bug Frown

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 06:35pm
By: Anonymous

Quote by: cordiste

Hi Michael,

My question is are you able to add a picture to a story with advanced editor on the demo.geeklog.net?

Because I can't. Seems to be a big bug Frown

::Ben



Thats interesting...I can't either. I checked and double checked the entire setup. Seems to not work. That was one of the things I did not check when I upgraded the demo site.

Michael

Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 07:09pm
By: ::Ben

I fire a bug report Wink

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 07:28pm
By: Anonymous

You didn't understand me, I have my own site and admins get FCKEditor by default, whereas regular logged in users get the plaintext editor by default. I want the latter to get FCKEditor by default just as well.

Re: Geeklog 1.5.1 and advanced editor

Posted on: 09/10/08 07:42pm
By: Anonymous

Quote by: Guest

You didn't understand me, I have my own site and admins get FCKEditor by default, whereas regular logged in users get the plaintext editor by default. I want the latter to get FCKEditor by default just as well.



Okay, we'll see how it goes with the Advanced editor. Anonymous users will not get the full features as they do when they are logged in.

Michael

Re: Geeklog 1.5.1 and advanced editor

Posted on: 10/10/08 07:33am
By: Anonymous

Again, I am talking about logging in users (who also happen to be topic/story admins) who get the plaintext editor by default, whereas root admins get FCKEditor by default. I want the former to get FCKEditor by default just well.

Re: Geeklog 1.5.1 and advanced editor

Posted on: 10/10/08 10:08am
By: Anonymous

Quote by: Guest

Again, I am talking about logging in users (who also happen to be topic/story admins) who get the plaintext editor by default, whereas root admins get FCKEditor by default. I want the former to get FCKEditor by default just well.



That is all configurable in the GUI of the setup. We have it set like this by default for security because it is a demo site. The features can be changed on your own web site setup.

Michael

Re: Geeklog 1.5.1 and advanced editor

Posted on: 10/10/08 11:02am
By: Anonymous

So in my own site, where is the place in which I can tell which user type gets which editor?

Re: Geeklog 1.5.1 and advanced editor

Posted on: 10/10/08 04:21pm
By: ::Ben

Anonymous,

Did you try in Config - Users and submission - User submission - Default post mode - HTML Formatted ?

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 11/10/08 04:17pm
By: Anonymous

On my website I can't upload images using the fckeditor. I can't even browse the server because I can't make out where it is trying to browse and there are no images in the folder. Can anyone tell me where the editor should upload images to?

Re: Geeklog 1.5.1 and advanced editor

Posted on: 11/10/08 05:16pm
By: ::Ben

Hi antiqueone,

Images are store in yourgeeklog.com/images/library/Image folder and library and Image folders must be writable.

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 11/10/08 08:31pm
By: Anonymous

Quote by: cordiste

Hi antiqueone,

Images are store in yourgeeklog.com/images/library/Image folder and library and Image folders must be writable.

::Ben



See this bug report at http://project.geeklog.net/tracking/view.php?id=757 It appears to be wide spread.

Michael

Re: Geeklog 1.5.1 and advanced editor

Posted on: 12/10/08 12:55pm
By: ::Ben

As Dirk suggest in the bugs tracker some code from the old config.php are missing to allow advanced-editor to work. This code was:

PHP Formatted Code

/* Optional HTML Tags that will be enabled if advanced editor is enabled
 * Posible to add tags to the allowable general USER $_CONF['user_html'] as well
*/

if ($_CONF['advanced_editor']) {
    $_CONF['admin_html']['a']       = array('href' => 1, 'title' => 1, 'id' => 1, 'lang' => 1, 'name' => 1, 'type' => 1, 'rel' => 1);
    $_CONF['admin_html']['hr']      = array ('style' => 1);
    $_CONF['admin_html']['ol']      = array ('style' => 1);
    $_CONF['admin_html']['ul']      = array ('style' => 1);
    $_CONF['admin_html']['caption'] = array ();
    $_CONF['admin_html']['table']   = array ('class' => 1, 'id' => 1, 'style' => 1, 'align' => 1, 'width' => 1,
                                             'border' => 1, 'cellspacing' => 1, 'cellpadding' => 1);
    $_CONF['admin_html']['tbody']   = array ();
    $_CONF['admin_html']['img']     = array('src' => 1, 'width' => 1, 'height' => 1, 'vspace' => 1, 'hspace' => 1,
                                            'dir' => 1, 'align' => 1, 'valign' => 1, 'border' => 1, 'lang' => 1,
                                            'longdesc' => 1, 'title' => 1, 'id' => 1, 'alt' => 1);
    $_CONF['admin_html']['font']    = array('face' => 1, 'size' => 1, 'style' => 1);
}


So, if you need advanced editor to work with pictures you can hack for exemple your lib-story.php and add this code in the beginning of the STORY_renderArticle function (near line 67) like this:

PHP Formatted Code

function STORY_renderArticle( &$story, $index='', $storytpl='storytext.thtml', $query='')
{
    global $_CONF, $_TABLES, $_USER, $LANG01, $LANG05, $LANG11, $LANG_TRB,
           $_IMAGE_TYPE, $mode;

    static $storycounter = 0;

        /* Optional HTML Tags that will be enabled if advanced editor is enabled
 * Posible to add tags to the allowable general USER $_CONF['user_html'] as well
*/

if ($_CONF['advanced_editor']) {
    $_CONF['admin_html']['a']       = array('href' => 1, 'title' => 1, 'id' => 1, 'lang' => 1, 'name' => 1, 'type' => 1, 'rel' => 1);
    $_CONF['admin_html']['hr']      = array ('style' => 1);
    $_CONF['admin_html']['ol']      = array ('style' => 1);
    $_CONF['admin_html']['ul']      = array ('style' => 1);
    $_CONF['admin_html']['caption'] = array ();
    $_CONF['admin_html']['table']   = array ('class' => 1, 'id' => 1, 'style' => 1, 'align' => 1, 'width' => 1,
                                             'border' => 1, 'cellspacing' => 1, 'cellpadding' => 1);
    $_CONF['admin_html']['tbody']   = array ();
    $_CONF['admin_html']['img']     = array('src' => 1, 'width' => 1, 'height' => 1, 'vspace' => 1, 'hspace' => 1,
                                            'dir' => 1, 'align' => 1, 'valign' => 1, 'border' => 1, 'lang' => 1,
                                            'longdesc' => 1, 'title' => 1, 'id' => 1, 'alt' => 1);
    $_CONF['admin_html']['font']    = array('face' => 1, 'size' => 1, 'style' => 1);
}


Maybe it will be not the right place for the bug fix... but now it's working Smile

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 12/10/08 01:06pm
By: ::Ben

Update

It's not a good fix because with it you can record a story with picture but you can't edit it no more. Correction are not recorded.

Need to elaborate a cleaner fix Frown

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 12/10/08 05:29pm
By: Anonymous

Quote by: cordiste

Hi antiqueone,

Images are store in yourgeeklog.com/images/library/Image folder and library and Image folders must be writable.

::Ben



Thanks Ben, brilliant, administrator can now upload images and insert them in stories.

Re: Geeklog 1.5.1 and advanced editor

Posted on: 15/10/08 01:13pm
By: Anonymous

Quote by: cordiste

Did you try in Config - Users and submission - User submission - Default post mode - HTML Formatted ?


Thanks, it worked! However, why is it called HTML Formatted if it doesn't use the HTML mode (which is a mode of its own)? Also, how come the root admin must use the advanced editor by default regardless of that option?

Re: Geeklog 1.5.1 and advanced editor

Posted on: 15/10/08 04:09pm
By: ::Ben

Yes advanced editor is magic Smile

You write Hello world in plain text and the advanced editor with the help of javascript change it to <p>Hello world</p>. You can view the source code hitting the source bouton or switch to html mode.

So no confusion, it is html formatted whitch is store in the db when you enable advenced editor and publish content in this mode.

::Ben

Re: Geeklog 1.5.1 and advanced editor

Posted on: 15/10/08 07:48pm
By: Anonymous

Regardless, Geeklog has a mode called HTML mode on its own. In live edit you get to choose between text mode, HTML mode and advanced editor. Why don't you get the same choice in the config?

And again, how come the root admin always gets the advanced editor regardless of the aforementioned choice?

Re: Geeklog 1.5.1 and advanced editor

Posted on: 16/10/08 08:49am
By: ::Ben

Why don't you get the same choice in the config?

I think it is historical. Advanced editor is like a "layer" came to geeklog in 2006, it's why his setting is separate from old plaintext/html setting. Maybe it would be nice if the Default Post Mode setting is just before the Advanced Editor setting in the config aera. Anyway, it's a nice feature to have separate settings because you can disable FCKEditor and set another like Tinymce for exemple.

And again, how come the root admin always gets the advanced editor regardless of the aforementioned choice?

If you enable avanced editor, his setting is master (Sorry I don't know the right word in english).

::Ben


Re: Geeklog 1.5.1 and advanced editor

Posted on: 23/11/08 04:28pm
By: ::Ben

To allow image in story with FCKEditor:

In the config set Skip HTML Filter for Root to true or allow the <img> tag for story admins as Dirk suggested here

::Ben


Geeklog - Forum
https://www.geeklog.net/forum/viewtopic.php?showtopic=84599