Subject: TAG plugin BUG

Posted on: 03/07/08 04:18am
By: Anonymous

I just faced an issue with the TAG plugin,

I posted an article with a future date (so that it gets published at a later time)

But the Tags on the post has been picked up by the plugin and displays the same in the results.

I have had warnings from Google Webmaster in the past for stories with future dates getting submitted to the search engine. This means Google recognizes the date of the article as mentioned on the article page...

Re: TAG plugin BUG

Posted on: 03/07/08 02:05pm
By: beewee

Oops, even if I remove the Tags, I can still see (while logged out!) the whole story, which will be published next monday!

After that, I disabled a the plugin, made a new story for August 2008 and anyone can see it....! Let's have a look at the demo site, to see if it's a Geeklog bug!!

EDIT: It's a Geeklog bug I'm afraid. I'm logged in at the demosite with IE, made a story for August 2008 and anyone can see it already!!

Re: TAG plugin BUG

Posted on: 03/07/08 02:23pm
By: Dirk

Not good :shock:

The draft flag doesn't seem to have an effect either. As a workaround: Uncheck the "Anonymous R" flag.

bye, Dirk

Re: TAG plugin BUG

Posted on: 03/07/08 02:40pm
By: beewee

That's too bad, there are people already using GL1.5 on a production site...

I've just ordered my webdesign department to install GL1.5 and port one of our largest sites to GL. Any idea when it's fixed in CVS? This is quite annoying since I have to port 3 large sites to GL in August. They have to be ready in September before a large fair. My collegues will try to update the Autotags plugin, but there's hardly any time for more bugs to resolve since they also have to copy, paste and redesign hundreds of HTML pages to the Static Pages.

Re: TAG plugin BUG

Posted on: 03/07/08 02:47pm
By: Dirk

Quick'n'dirty fix (no guarantees, but looks good):

Re-activate this piece of code in article.php:
PHP Formatted Code
    /*$access = SEC_hasAccess ($A['owner_id'], $A['group_id'],
            $A['perm_owner'], $A['perm_group'], $A['perm_members'],
    if (($access == 0) OR !SEC_hasTopicAccess ($A['tid']) OR
        (($A['draft_flag'] == 1) AND !SEC_hasRights ('story.edit'))) {*/

i.e. remove the /* and */ (lines 129ff) and then duplicate these three lines at the end of the file:
PHP Formatted Code
} else {
    $display .= COM_refresh($_CONF['site_url'] . '/index.php');

i.e. so that you have that block of code twice.

bye, Dirk

Re: TAG plugin BUG

Posted on: 03/07/08 02:59pm
By: THEMike

PHP Formatted Code

Index: system/classes/story.class.php
RCS file: /cvsroot/geeklog/Geeklog-1.x/system/classes/story.class.php,v
retrieving revision 1.29
diff -u -r1.29 story.class.php
--- system/classes/story.class.php      22 Jun 2008 20:23:07 -0000      1.29
+++ system/classes/story.class.php      3 Jul 2008 18:58:29 -0000
@@ -495,6 +495,8 @@
                     return STORY_PERMISSION_DENIED;
                 } elseif ($this->_access == 2 && $mode != 'view') {
                     return STORY_EDIT_DENIED;
+                } elseif ((($this->_access == 2) && ($mode == 'view')) && (($this->_draft_flag == 1) || ($this->_date > time()))) {
+                        return STORY_INVALID_SID;
             } else {
                 return STORY_INVALID_SID;
@@ -801,6 +803,9 @@
     function loadSubmission()
         $array = $_POST;
+        $this->_expire = time();
+        $this->_expiredate = 0;
         // Handle Magic GPC Garbage:
         while (list($key, $value) = each($array))

Re: TAG plugin BUG

Posted on: 03/07/08 03:13pm
By: beewee

My god, that's awfully quick. My compliments!

Re: TAG plugin BUG

Posted on: 03/07/08 03:22pm
By: THEMike

I'd wait and make sure it works for you first ;-)

Re: TAG plugin BUG

Posted on: 04/07/08 02:52pm
By: Laugh

There are several bugs with the plugin which I posted over here a while ago.

Deleting of tags in the admin interface doesn't work.
Character Set problem.
Related Draft stories are visible when you click on a tag in the cloud.
I also sometimes get blank items in the list of stories when you click on a tag in the cloud

I've emailed the author but heard nothing back so I am not sure if these issues will be fixed anytime soon.

Re: TAG plugin BUG

Posted on: 05/07/08 09:04am
By: Anonymous

I couldn't get the issues with the draft... A draft when posted with the Tags does appear in the Tag Cloud but the access to the same is denied to non admins (on my GL 1.4.1).

As for post dated articles the link was always active but since the URL is not published anywhere it is not visited by anyone, and the same is used by me to give preview of the articles coming up to others(I thought its normal lol) ...

neways /// Is the fix that is posted above working?

Geeklog - Forum