Topics

User Functions

Events

There are no upcoming events

What's New

Stories

No new stories

Comments last 2 weeks

No new comments

Trackbacks last 2 weeks

No new trackback comments

Links last 2 weeks

No recent new links

NEW FILES last 14 days

No new files

Welcome to Geeklog Tuesday, May 21 2013 @ 07:00 PM EDT


 Forum Index > General Discussions > Feedback New Topic Post Reply
 Edit icon missing in static pages?
   
mystral-kk
 06/16/08 09:18AM (Read 1672 times)  
++++-
Regular Poster

Status: offline


Registered: 03/19/06
Posts: 89

I installed GL-1.5 quite easily (thanks, developers!) and found no edit icon in static pages in the center block (when displaying the home page of my site with the default Professional theme), though I logged in as admin.


After doing a little search through the code, I think this has something to do with geeklog/plugins/staticpages/templates/centerblock.thtml, which doesn't contain {edit_icon} template var. After I added {edit_icon} to the template file, edit icon shows itself as in GL-1.4.1.


-- mystral-kk, "Every cloud has a silver lining."
 
Profile Email Website
 Quote
Dirk
 06/16/08 02:19PM  
AAAAA
Admin

Status: offline


Registered: 01/12/02
Posts: 13027
That was actually a conscious decision:
Static Pages plugin
-------------------
- Moved the print and edit icons to the bottom of a static page in the default
staticpage.thtml template file. Also removed the icons from the default
centerblock.thtml template file and defined the {lastupdate} and {hits}
variables there (bug #0000628 ) [Dirk]

The old template was trying to make it look like a story block, but it didn't quite work out and you don't usually need the printer icon on a centerblock. And then I couldn't find a good spot to put the edit icon, so I took that out as well.

But since it's a template, it's easy to put back in. If you have any suggestion as to where the edit icon should go, let's hear them.

bye, Dirk

 
Profile Email Website
 Quote
mystral-kk
 06/17/08 08:56AM  
++++-
Regular Poster

Status: offline


Registered: 03/19/06
Posts: 89
Thanks for the quick reply, Dirk.

For non-admin users to see the site, I quite agree with you. Date and print icons are of little use. However, for admins to edit static pages, especially when they are designing the static pages, the edit icon which you can click at the home page is quite handy.

So I suggest changing centerblock.thtml like:

{content}
<p class="alignright">{edit_icon}</p>

-- mystral-kk, "Every cloud has a silver lining."
 
Profile Email Website
 Quote
Dirk
 06/17/08 12:41PM  
AAAAA
Admin

Status: offline


Registered: 01/12/02
Posts: 13027
Quote by: mystral_kk

So I suggest changing centerblock.thtml like:

{content}
<p class="alignright">{edit_icon}</p>


That would of course leave an empty paragraph for everyone without edit permissions. Shouldn't hurt, but it's not very elegant.

bye, Dirk

 
Profile Email Website
 Quote
jmucchiello
 06/17/08 02:09PM  
+++++
Full Member

Status: offline


Registered: 08/29/05
Posts: 985
If you are running CTL you can do this to avoid the extra paragraph for users that can't edit the static page:
{content}
{!if edit_icon}
<p class="alignright">{edit_icon}</p>
{!endif}

 
Profile Email
 Quote
mystral-kk
 06/18/08 10:35AM  
++++-
Regular Poster

Status: offline


Registered: 03/19/06
Posts: 89
Quote by: Dirk

Quote by: mystral_kk

So I suggest changing centerblock.thtml like:

{content}
<p class="alignright">{edit_icon}</p>


That would of course leave an empty paragraph for everyone without edit permissions. Shouldn't hurt, but it's not very elegant.


Sure, it's not very elegant, but I would prefer handiness to elegance.

Joe, thanks for your info. I haven't introduced CTL yet, but when I upgrade my site to GL-1.5, I will try CTL.

-- mystral-kk, "Every cloud has a silver lining."
 
Profile Email Website
 Quote
::Ben
 06/18/08 10:57AM  
+++++
Full Member

Status: offline


Registered: 01/14/05
Posts: 1359
+1 for a direct link to edit static pages Smile

::Ben

We speak french on http://geeklog.fr
 
Profile Email Website
 Quote
Content generated in: 4.06 seconds
New Topic Post Reply

Normal Topic Normal Topic
Sticky Topic Sticky Topic
Locked Topic Locked Topic
New Post New Post
Sticky Topic W/ New Post Sticky Topic W/ New Post
Locked Topic W/ New Post Locked Topic W/ New Post
View Anonymous Posts 
Able to post 
Filtered HTML Allowed 
Censored Content